Skip to content

Conversation

@jdonszelmann
Copy link
Contributor

As per #149266

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jdonszelmann
Copy link
Contributor Author

Implementing exactly_one in terms of collect_array seems to generate the exact same code as a dedicated implementation:
https://godbolt.org/z/Tc6P5MhrE

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from 050e278 to 1e50c8a Compare November 24, 2025 13:27
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from 1e50c8a to 6b0bbcc Compare November 24, 2025 13:34
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from 6b0bbcc to 710c1d4 Compare November 24, 2025 14:12
@jdonszelmann
Copy link
Contributor Author

As you can see from the 2nd commit and the CI failures, since exactly_one conflicts with itertools we get some FCWs. How do we usually deal with those? I doubt this is the first iterator method that also already existed in itertools.

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from 710c1d4 to 5e40f3f Compare November 24, 2025 15:11
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added T-clippy Relevant to the Clippy team. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 24, 2025
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from 5e40f3f to d65444f Compare November 24, 2025 16:07
@jdonszelmann jdonszelmann force-pushed the exact-length-collection branch from d65444f to f201752 Compare November 24, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants