[EXPERIMENT] DelimSpan::from_single() experiment for better open and close values. #149282
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental changes to
DelimSpan::from_single()with more conservative default values when the open and close are not obvious to not break underlying assumptions about None delimiter spans of metavars.This experiment is updated as asked here: #149052 (comment) to only update the obvious case. Compared to this experiment which is less conservative: #149112 which changes the spans to always to be at least an empty span located at the end and start of the provided span for the open and close of
DelimSpanr? @petrochenkov