Skip to content

Conversation

@ShoyuVanilla
Copy link
Member

@ShoyuVanilla ShoyuVanilla commented Nov 24, 2025

I took a some weird hack that lowers the following macro call

format_args!("{x} {x}");

into

{
    super let args = (&x,);
    super let args = [format_argument::new_display(args.0)];
    let __issue_145739 = (&x, (), ());
    unsafe {
        format_arguments::new(b"\xc0\x01 \xc8\x00\x00\x01\n\x00",
            &args)
    }
}

and then look for those let stmt with __issue_145739 later in the late lint pass.

It's because in early lint, we don't have much information other than AST, while in late lint, we have quite much information but not for AST 😂 So I have to leave some information about AST before executing late lint and I think this would be okay as this lint will be used only for crater runs

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@theemathas theemathas added the needs-crater This change needs a crater run to check for possible breakage in the ecosystem. label Nov 24, 2025
@rust-log-analyzer

This comment has been minimized.

@ShoyuVanilla
Copy link
Member Author

I have a crater permission by rust-lang/team#2038 but I'm not sure is this okay to run as I've never done it before 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-crater This change needs a crater run to check for possible breakage in the ecosystem. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants