Deny const auto traits #149307
Open
Deny const auto traits #149307
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
lapla-cogito
force-pushed
the
deny_const_auto_trait
branch
from
8eb8894 to
809379a
Compare
fmease
approved these changes
Nov 25, 2025
| LL | const auto trait Marker {} | ||
| | ^^^^^ | ||
| | | ||
| = help: remove the `const` keyword |
Member
There was a problem hiding this comment.
We could provide a structured suggestion but yeah, it's not really worth the effort.
Contributor
Author
There was a problem hiding this comment.
I initially thought about that, but decided not to, mainly because not every suggestion can be fixed automatically with rustfix, for example the code sample in the original issue that triggers a panic in next-gen solvers, and because we don't really have anything meaningful to add beyond what the current message already communicates.
fmease
added
S-waiting-on-author
Member
|
Thanks! Two small nitpicks |
lapla-cogito
force-pushed
the
deny_const_auto_trait
branch
2 times, most recently
from
44f4a9b to
0f63688
Compare
lapla-cogito
force-pushed
the
deny_const_auto_trait
branch
from
0f63688 to
3326fbd
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #149285
The AST validation now detects and rejects const auto traits. Additionally, I updated an existing test that was using
const unsafe auto trait.r? fmease