Replace Value::from_cycle_error with fallback queries
#149319
+487
−518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
Value::from_cycle_errortrait with fallback queries. Now logic for creating errored values for queries in cycle is delegated to the query implementation itself instead of being directly associated to query value type. Previously it required some work arounds like leaking values, and searching for queries looking similar to query we want to create an errored value for just to get itsDefIdkey which we already have couple of calls up the compiler's callstack.TODO: remove fallback queries for queries marked fatal_cycle, since those are unused
Fixes #142064