Skip to content

Conversation

@zetanumbers
Copy link
Contributor

@zetanumbers zetanumbers commented Nov 25, 2025

Replaces Value::from_cycle_error trait with fallback queries. Now logic for creating errored values for queries in cycle is delegated to the query implementation itself instead of being directly associated to query value type. Previously it required some work arounds like leaking values, and searching for queries looking similar to query we want to create an errored value for just to get its DefId key which we already have couple of calls up the compiler's callstack.

TODO: remove fallback queries for queries marked fatal_cycle, since those are unused

Fixes #142064

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: parallel: internal error: entered unreachable code

3 participants