-
Notifications
You must be signed in to change notification settings - Fork 14k
yet another improvment to rustdoc js typechecking #149327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some changes occurred in HTML/CSS/JS. |
|
r? @notriddle rustbot has assigned @notriddle. Use |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
| console.log(filterCrates); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| console.log(filterCrates); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops!
yea this was from testing to figure out which type signature was correct.
| if (active) { | ||
| const next = active.nextElementSibling; | ||
| if (next) { | ||
| // @ts-expect-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a comment explaining why this is okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SvgElement, MathMLElement, and HTMLElement all define .focus()
honestly i'm not even sure what hypothetical element would not have the ability to be focused.
biggest improvment is the docs for
FunctionTypeand the signatures for functions that accept names of crates were both slightly wrong, this has now been fixed.