Skip to content

Conversation

@weihanglo
Copy link
Member

7 commits in 9fa462fe3a81e07e0bfdcc75c29d312c55113ebb..2a7c4960677971f88458b0f8b461a866836dff59
2025-11-21 20:49:51 +0000 to 2025-11-25 19:58:07 +0000

@weihanglo weihanglo self-assigned this Nov 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

This is a bit in priority as there seems to be a regression: rust-lang/cargo#16299 in file locking.

@bors
Copy link
Collaborator

bors commented Nov 25, 2025

📌 Commit c2bbd6b has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2025
@bors
Copy link
Collaborator

bors commented Nov 26, 2025

⌛ Testing commit c2bbd6b with merge d8a7534...

@bors
Copy link
Collaborator

bors commented Nov 26, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing d8a7534 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 26, 2025
@bors bors merged commit d8a7534 into rust-lang:main Nov 26, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 26, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 80d8f29 (parent) -> d8a7534 (this PR)

Test differences

Show 13 test diffs

Stage 2

Additionally, 7 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d8a7534127d3d91d42b86decfcd4ef20429ac480 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 165.2s -> 192.3s (+16.4%)
  2. dist-aarch64-apple: 7497.0s -> 6302.4s (-15.9%)
  3. x86_64-gnu-llvm-20: 2835.4s -> 2425.8s (-14.4%)
  4. i686-gnu-2: 6155.1s -> 5315.8s (-13.6%)
  5. aarch64-gnu-debug: 4553.7s -> 3988.1s (-12.4%)
  6. i686-gnu-1: 8412.6s -> 7443.7s (-11.5%)
  7. x86_64-gnu-tools: 3732.2s -> 3306.3s (-11.4%)
  8. dist-aarch64-msvc: 6567.8s -> 5835.7s (-11.1%)
  9. x86_64-gnu-debug: 7426.5s -> 6622.1s (-10.8%)
  10. pr-check-2: 2563.1s -> 2294.5s (-10.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d8a7534): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.3%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)
-1.8% [-1.8%, -1.8%] 1
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Cycles

Results (primary 3.8%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.8% [1.9%, 11.7%] 15
Regressions ❌
(secondary)
6.4% [1.6%, 8.5%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.5% [-5.9%, -3.0%] 2
All ❌✅ (primary) 3.8% [1.9%, 11.7%] 15

Binary size

Results (primary 0.2%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.3%] 8
Regressions ❌
(secondary)
0.2% [0.0%, 0.3%] 95
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.1%, 0.3%] 8

Bootstrap: 469.292s -> 479.37s (2.15%)
Artifact size: 386.82 MiB -> 386.91 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants