Don't suggest unwrap for Result in const #149344
Open
+56
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
lapla-cogito
force-pushed
the
const_unwrap_sugg
branch
from
ef8cc30 to
41e452c
Compare
lapla-cogito
force-pushed
the
const_unwrap_sugg
branch
from
41e452c to
80d7968
Compare
Kivooeo
requested changes
Nov 26, 2025
Comment on lines
2110
to
2111
| if self.tcx.is_diagnostic_item(sym::Result, adt.did()) { | ||
| ("a", "Result", "Err", ret_ty_matches(sym::Result)) |
Member
There was a problem hiding this comment.
what about just do
if self.tcx.is_diagnostic_item(sym::Result, adt.did()) &&
+ // comment with explanation or link to issue/pr
+ !self.tcx.hir_is_inside_const_context(expr.hir_id)
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #149316
Regarding
const fnthat returnsResult, we should avoid suggesting unwrapping. The original issue reported cases where types didn't match, but in practice, such suggestions may also appear when methods are not found, so this PR includes a fix for that case as well.