Skip to content

Conversation

@scrabsha
Copy link
Contributor

@scrabsha scrabsha commented Nov 26, 2025

Part of #131229.

r? @jdonszelmann

I think it's worth running the Windows test suite before merging that (I don't have the rights for this).

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2025
@rustbot

This comment has been minimized.

@jdonszelmann
Copy link
Contributor

uh, I think this should be the right job:
@bors try jobs=x86_64-msvc

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 26, 2025
Port the `#![windows_subsystem]` attribute to the new attribute system

try-job: x86_64-msvc
@rust-bors
Copy link

rust-bors bot commented Nov 26, 2025

💔 Test for 1e90a73 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling ureq v3.0.8
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `dev` profile [unoptimized] target(s) in 36.78s
     Running `target/debug/citool calculate-job-matrix`
Run type: TryJob { job_patterns: Some(["x86_64-msvc"]) }
Error: Failed to calculate job matrix

Caused by:
    Patterns `x86_64-msvc` did not match any auto jobs
##[error]Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants