-
Notifications
You must be signed in to change notification settings - Fork 14k
Tidying up UI tests [4/N] #149367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tidying up UI tests [4/N] #149367
Conversation
|
This PR modifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted it because I thought it was the same as entry-point/main-with-invalid-signiture.rs. What are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree with this
This comment has been minimized.
This comment has been minimized.
|
Thanks @bors r+ |
|
oh wait I forget to send a review :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in filename "signiture"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I missed! thanks
|
@bors r- |
|
r=me when fix and ci is green @bors delegate+ |
|
✌️ @reddevilmidzy, you can now approve this pull request! If @Kivooeo told you to " |
Relocate issues/issue-51022.rs to entry-point/main-with-lifetime-param.rs Relocate issue-50714.rs to entry-point/main-where-fn-bound.rs Rename issue-118772.rs to main-with-invalid-signature.rs and delete duplicate test remove ui/entry-point/issue-118772.rs in issues.txt Relocate fn-main/wrong-location.rs to entry-point/main-in-submodule.rs Remove fn-main directory Relocate issue-50688.rs to mismatched_types/array-len-is-closure.rs
Note
Intermediate commits are intended to help review, but will be squashed prior to merge.
part of #133895
Relocate 4 tests in fn-main and issues and remove fn-main directory
r? Kivooeo