-
Notifications
You must be signed in to change notification settings - Fork 14k
Do not trust bootstrap about git hash availability #149377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jieyouxu
wants to merge
3
commits into
rust-lang:main
Choose a base branch
from
jieyouxu:git-hash-availability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+50
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 27, 2025
Do not trust bootstrap about git hash availability try-job: aarch64-apple try-job: test-various
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Since the bootstrap implementation can contain bugs. Instead, we use `RUSTC_TEST_GIT_HASH` env var that is directly set by CI, or by the user locally.
To always run `tests/run-make/version-verbose-commit-hash` in test jobs.
299c1fe to
39e27c1
Compare
Member
Author
|
@bors try |
rust-bors bot
added a commit
that referenced
this pull request
Nov 27, 2025
Do not trust bootstrap about git hash availability try-job: aarch64-apple try-job: test-various
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CI
Area: Our Github Actions CI
A-compiletest
Area: The compiletest test runner
A-rustc-dev-guide
Area: rustc-dev-guide
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bootstrap implementation can contain bugs. See #132845 and #132875.
Instead, we use
RUSTC_TEST_GIT_HASHenv var that is directly set by CI, or by the user locally, to control when thetests/run-make/version-verbose-commit-hashgets run. Note that locally, settingRUSTC_TEST_GIT_HASH=1only forces the test to run; the test will only pass if git hash is available, i.e. explicitly opt-in, or using a non-dev channel.Fixes #132875.
r? ghost
try-job: aarch64-apple
try-job: test-various