Skip to content

Conversation

@RustyYato
Copy link
Contributor

@RustyYato RustyYato commented Dec 5, 2025

Fixes #149687

r? @saethlin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 5, 2025
@saethlin
Copy link
Member

saethlin commented Dec 5, 2025

@bors r+ roll-up=iffy (may perturb perf)

@bors
Copy link
Collaborator

bors commented Dec 5, 2025

📌 Commit ae3536e has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025
@saethlin
Copy link
Member

saethlin commented Dec 5, 2025

@bors rollup=iffy

Yeah I'm on a phone. We really are struggling here aren't we.

@rust-log-analyzer

This comment has been minimized.

@matthiaskrgr
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2025
@matthiaskrgr
Copy link
Member

@bors try @rust-timer queue

(since we're waiting anyway..)

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 5, 2025
Add `#[inline]` to `Layout::is_size_align_valid`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 5, 2025
@rust-log-analyzer

This comment has been minimized.

@RustyYato RustyYato force-pushed the inline-layout-helper branch from 0972f69 to 7d9f9ad Compare December 5, 2025 20:48
@saethlin
Copy link
Member

saethlin commented Dec 5, 2025

since we're waiting anyway

Hunh?

Oh. The CI failure is hidden. Ugh

@rust-bors
Copy link

rust-bors bot commented Dec 5, 2025

☀️ Try build successful (CI)
Build commit: d86c359 (d86c359e479b8a350b9a5dd09229e69fe6502004, parent: 66428d92bec337ed4785d695d0127276a482278c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d86c359): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
1.2% [0.1%, 4.3%] 4
Regressions ❌
(secondary)
1.3% [0.2%, 2.2%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [0.1%, 4.3%] 4

Max RSS (memory usage)

Results (primary -0.4%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [1.7%, 2.8%] 3
Regressions ❌
(secondary)
5.2% [5.2%, 5.2%] 1
Improvements ✅
(primary)
-3.0% [-4.3%, -1.5%] 3
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) -0.4% [-4.3%, 2.8%] 6

Cycles

Results (primary 5.9%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.9% [5.9%, 5.9%] 1
Regressions ❌
(secondary)
3.3% [2.8%, 3.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-3.3%, -2.6%] 2
All ❌✅ (primary) 5.9% [5.9%, 5.9%] 1

Binary size

Results (primary 0.0%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.2%] 16
Regressions ❌
(secondary)
1.0% [0.1%, 2.6%] 21
Improvements ✅
(primary)
-0.3% [-0.7%, -0.1%] 5
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.7%, 0.2%] 21

Bootstrap: 470.249s -> 473.304s (0.65%)
Artifact size: 386.85 MiB -> 386.93 MiB (0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout::is_size_align_valid no longer inlined since 1.82.0

7 participants