-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Add #[inline] to Layout::is_size_align_valid
#149690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors r+ roll-up=iffy (may perturb perf) |
|
@bors rollup=iffy Yeah I'm on a phone. We really are struggling here aren't we. |
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
|
@bors try @rust-timer queue (since we're waiting anyway..) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add `#[inline]` to `Layout::is_size_align_valid`
This comment has been minimized.
This comment has been minimized.
0972f69 to
7d9f9ad
Compare
Hunh? Oh. The CI failure is hidden. Ugh |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (d86c359): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.4%, secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 5.9%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 470.249s -> 473.304s (0.65%) |
Fixes #149687
r? @saethlin