-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Ability to omit : () on const item declarations
#149738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GrigorenkoPV
wants to merge
10
commits into
rust-lang:main
Choose a base branch
from
GrigorenkoPV:const_unit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This comment has been minimized.
This comment has been minimized.
939012d to
3ecc105
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-lang
Relevant to the language team
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constblocks #149226constblocks as amoditem #149174As suggested in #149174 (comment), this PR adds an ability to omit
: ()from const item declarations. If the type is omitted, it defaults to(). This is similar to how function declarations treat-> ().Implementation details:
#![feature(const_items_unit_type_default)]with the same tracking issue as for#![feature(const_block_items)]ast::ConstItem'styis changed fromBox<ast::Ty>intoast::FnRetTy, which is like anOption<Box<Ty>>but with aSpanfor theNonevariant.staticitems with unspecified type still give an error, just as beforeconstitems with an unspecified type no longer give the previous error, but instead demand that you have the new feature enabled and fallback to: ().constitems with no type specified inASTget a()in HIRTODO:
constitem #69396. Maybe instead of falling back to: (), fallback to: _(as it was before) when the feature is not enabled?constblocks #149226FnRetTyor rename it?()" not during AST->HIR, but later on?: ()for static items too? for consistency. despitestatic: ()being kinda useless.