Skip to content

On name resolution error in parameter list, suggest possible const typo #149753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
estebank wants to merge 2 commits into
base: main
Choose a base branch
from
Open

On name resolution error in parameter list, suggest possible const typo #149753

estebank wants to merge 2 commits into from

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Dec 8, 2025 •
edited
Loading

Fix #149660.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

estebank
estebank commented Dec 8, 2025
View reviewed changes
tests/ui/const-generics/const-argument-typo.stderr Outdated
Comment on lines 10 to 19
error[E0747]: unresolved item provided when a constant was expected
--> $DIR/const-argument-typo.rs:8:11
|
LL | foo::<CONS>();
| ^^^^
|
help: if this generic argument was intended as a const parameter, surround it with braces
|
LL | foo::<{ CONS }>();
| + +
Copy link
Contributor Author

@estebank estebank Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be shown. When naively silencing it, an inference error is displayed instead, which is just as bad.

Copy link
Contributor Author

@estebank estebank Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit addresses this.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

Some changes occurred in need_type_info.rs

cc @lcnr

HIR ty lowering was modified

cc @fmease

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@madsmtm madsmtm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resolve error in const params doesn't do fuzzy search for consts

4 participants

@estebank @rustbot @rust-log-analyzer @madsmtm