Rollup of 11 pull requests #149798

matthiaskrgr · 2025-12-09T05:17:29Z

Successful merges:

Suppress the error for private fields with non_exhaustive attribute #147585 (Suppress the error for private fields with non_exhaustive attribute)
Emit check-cfg lints during attribute parsing rather than evaluation #149215 (Emit check-cfg lints during attribute parsing rather than evaluation)
Add release notes for 1.92.0 #149652 (Add release notes for 1.92.0)
rustdoc book: mention inner doc attribute #149720 (rustdoc book: mention inner doc attribute)
lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE)
Retire opt_str2 from compiletest cli parsing #149754 (Retire opt_str2 from compiletest cli parsing)
bootstrap: Use a CompiletestMode enum instead of bare strings #149755 (bootstrap: Use a CompiletestMode enum instead of bare strings)
Add inline attribute to generated delegation function if needed #149763 (Add inline attribute to generated delegation function if needed)
test: Add a test for 146133 #149772 (test: Add a test for 146133)
Fix typo "an" → "and" #149779 (Fix typo "an" → "and")
Remove [no-mentions] handler in the triagebot config #149782 (Remove [no-mentions] handler in the triagebot config)

Failed merges:

Correctly provide suggestions when encountering async fn with a dyn Trait return type #148491 ( Correctly provide suggestions when encountering async fn with a dyn Trait return type)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…n#149215

Instead of allowing them to be missing and using some placeholder "(none)" value instead.

Instead of possibly falling back to "(none)" when they are not specified.

We either have the value of a flag specified, or we don't. Use `Option<...>` to represent that -- don't invent a new "(none)" sentinel value...

This derive was an artifact of test-only method `Cache::all` wanting to automatically sort its output to hide HashMap iteration order. We can achieve an equivalent result by requiring the caller to provide a projection function that returns results that _are_ sortable.

Replaced _binder with _

Even if a crate is marked as #![no_builtins], we can still generate bitcode for rlib, but we cannot emit bitcode to the linker in rustc's LTO.

https://github.blog/changelog/2025-11-07-removing-notifications-for-mentions-in-commit-messages/

…ess-private-fields, r=Kivooeo Suppress the error for private fields with non_exhaustive attribute Fixes rust-lang#147513

…szelmann Emit `check-cfg` lints during attribute parsing rather than evaluation The goal of this PR is to make the `eval_config_entry` not have any side effects, by moving the check-cfg lints to the attribute parsing. This also helps ensure we do emit the lint in situations where the attribute happens to be parsed, but never evaluated. cc ``@jdonszelmann`` ``@Urgau`` for a vibe check if you feel like it

Add release notes for 1.92.0 cc ``@rust-lang/release`` r? ``@BoxyUwU``

rustdoc book: mention inner doc attribute Couldn't find this documented anywhere else.

lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE Fixes rust-lang#149719 This PR replaces the `todo!("FIXME(unsafe_binder)")` branch in the `improper_ctypes` lint with a proper diagnostic. Previously, using an unsafe binder inside an extern `"C"` block caused an internal compiler error. This fix now ensures that the compiler now emits a clear and stable error message explaining that types containing unsafe binders are not yet supported in FFI. A new UI test `(unsafe-binder-basic.rs)` is included to ensure this behavior remains stable and prevent regressions.

Retire `opt_str2` from compiletest cli parsing We have `Option<..>`, we don't need to invent "(none)" as option-at-home. - More specifically, when some test suite expect certain values to be present, they should `.expect(..)` the value, and not potentially receive some "(none)" in some cases. r? Zalathar

bootstrap: Use a `CompiletestMode` enum instead of bare strings This gives better static checking when dealing with compiletest modes in bootstrap, especially for those modes that overlap with the name of a test suite directory. r? jieyouxu (or bootstrap)

…petrochenkov Add inline attribute to generated delegation function if needed This PR adds a functionality to add #[inline(always)] attribute to generated functions from delegation, if some #[inline(..)] attribute is already specified on the delegation then we do nothing. This PR is a part of the delegation feature rust-lang#118212 and addresses `Add implicit #[inline] unless specified otherwise` item. r? ``@petrochenkov``

…to, r=jieyouxu test: Add a test for 146133 This is a test without using `-Zbuild-std` for rust-lang#146133. There is another test using `-Zbuild-std`: rust-lang/cargo#16277. Even if a crate is marked as `#![no_builtins]`, we can still generate bitcode for rlib, but we cannot emit bitcode to the linker in rustc's LTO.

Fix typo "an" → "and"

…, r=Kobzol Remove `[no-mentions]` handler in the triagebot config This PR removes the `[no-mentions]` handler in the triagebot config as [GitHub is removing notifications for ``@-mentions`` in commit messages on December 8th 2025.](https://github.blog/changelog/2025-11-07-removing-notifications-for-mentions-in-commit-messages/) cf. rust-lang/triagebot#2225

matthiaskrgr · 2025-12-09T05:17:55Z

@bors r+ rollup=never p=5

bors · 2025-12-09T05:17:58Z

📌 Commit 288e970 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-12-09T08:20:55Z

⌛ Testing commit 288e970 with merge d5525a7...

bors · 2025-12-09T11:37:18Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d5525a7 to main...

rust-timer · 2025-12-09T11:40:30Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147585	Suppress the error for private fields with non_exhaustive a…	`6973225b3c523a855e862a7029020a1a249560a3` (link)
#149215	Emit `check-cfg` lints during attribute parsing rather than…	`9a56c9b6afb8081ffc061c77d222dc988df9cbd6` (link)
#149652	Add release notes for 1.92.0	`5a0c1d466116a8ebf3ec59fab45b735c5aa279c6` (link)
#149720	rustdoc book: mention inner doc attribute	`08d07e90811e8fa33d34605cc7a60bf3841e880c` (link)
#149730	lint: emit proper diagnostic for unsafe binders in improper…	`489e9c169757203dd4eefbd6dad4f2edf896b05b` (link)
#149754	Retire `opt_str2` from compiletest cli parsing	`19f0f763dc05d954867138bfa86e829d2203603e` (link)
#149755	bootstrap: Use a `CompiletestMode` enum instead of bare str…	`e06e775977e4d921056e80c2dcc1d47b27ef6cc3` (link)
#149763	Add inline attribute to generated delegation function if ne…	`b22927e00dfd17e2e7c8c0379b508888b3f9c023` (link)
#149772	test: Add a test for 146133	`f2b9d6e9b3f876eba60a950eb833548876d48c0e` (link)
#149779	Fix typo "an" → "and"	`5bcc4fbf9850f8a52943ea398767b158f104e58b` (link)
#149782	Remove `[no-mentions]` handler in the triagebot config	`e62ce8d73059066188445d718bb5415602be0b07` (link)

previous master: 018d26972e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-12-09T11:40:37Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 018d269 (parent) -> d5525a7 (this PR)

Test differences

Show 17 test diffs

Stage 1

[pretty] tests/pretty/delegation_inline_attribute.rs: [missing] -> pass (J0)
[run-make] tests/run-make/no-builtins-linker-plugin-lto: [missing] -> pass (J0)
[ui] tests/ui/check-cfg/nested-cfg.rs: [missing] -> pass (J0)
[ui] tests/ui/lint/improper-ctypes/unsafe-binder-basic.rs: [missing] -> pass (J0)
[ui] tests/ui/privacy/non-exhaustive-with-private-fields-147513.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/check-cfg/nested-cfg.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/improper-ctypes/unsafe-binder-basic.rs: [missing] -> pass (J1)
[ui] tests/ui/privacy/non-exhaustive-with-private-fields-147513.rs: [missing] -> pass (J1)
[pretty] tests/pretty/delegation_inline_attribute.rs: [missing] -> pass (J2)
[run-make] tests/run-make/no-builtins-linker-plugin-lto: [missing] -> ignore (only executed when the target is x86_64-unknown-linux-gnu) (J3)
[run-make] tests/run-make/no-builtins-linker-plugin-lto: [missing] -> pass (J4)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d5525a73009e2c61b09daa69df79064530bd4dcf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 6859.4s -> 9743.1s (+42.0%)
dist-aarch64-apple: 6106.3s -> 8142.8s (+33.4%)
i686-gnu-nopt-1: 7269.6s -> 8685.2s (+19.5%)
x86_64-rust-for-linux: 2698.0s -> 3220.6s (+19.4%)
aarch64-gnu-llvm-20-1: 3322.0s -> 3927.0s (+18.2%)
x86_64-gnu-debug: 6043.0s -> 7034.9s (+16.4%)
x86_64-gnu-llvm-20: 2436.8s -> 2822.1s (+15.8%)
aarch64-gnu-llvm-20-2: 2204.4s -> 2493.4s (+13.1%)
x86_64-gnu-gcc: 3117.9s -> 3514.4s (+12.7%)
pr-check-2: 2325.6s -> 2612.7s (+12.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-09T12:18:51Z

Finished benchmarking commit (d5525a7): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.1%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-2.1%, 2.8%]	2

Cycles

Results (primary -2.3%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.2%, 4.8%]	3
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	27
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	3
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	27

Bootstrap: 472.223s -> 472.272s (0.01%)
Artifact size: 389.03 MiB -> 389.04 MiB (0.00%)

chenyukang and others added 27 commits October 11, 2025 19:15

Suppress the error for private fields with non_exhaustive attribute

6a709e7

Emit check-cfg lints during attribute parsing rather than evaluatio…

71b093f

…n#149215

Changes to uitests

e7df904

Add regression test for nested cfgs

01576a6

rustdoc book: mention inner doc attribute

a3a041d

compiletest: require host/target flags specified

260b1ff

Instead of allowing them to be missing and using some placeholder "(none)" value instead.

compiletest: make presence/absence of adb-related options clear

a7ad214

Instead of possibly falling back to "(none)" when they are not specified.

compiletest: retire opt_str2

72541e9

We either have the value of a flag specified, or we don't. Use `Option<...>` to represent that -- don't invent a new "(none)" sentinel value...

Use a CompiletestMode enum in bootstrap

dc8cdb1

lint: treat unsafe binders in improper_ctypes instead of ICE

0f4ec28

Replaced _binder with _

test: Add test for 146133

611c956

Even if a crate is marked as #![no_builtins], we can still generate bitcode for rlib, but we cannot emit bitcode to the linker in rustc's LTO.

Add inline attribute to generated delegation function if needed

8cf942d

Fix typo "an" → "and"

27a4aab

Remove [no-mentions] handler in the triagebot config

b8581dd

https://github.blog/changelog/2025-11-07-removing-notifications-for-mentions-in-commit-messages/

Add release notes for 1.92.0

90d2477

Rollup merge of rust-lang#147585 - chenyukang:yukang-fix-147513-suppr…

3c19acc

…ess-private-fields, r=Kivooeo Suppress the error for private fields with non_exhaustive attribute Fixes rust-lang#147513

Rollup merge of rust-lang#149652 - cuviper:relnotes-1.92.0, r=BoxyUwU

990b663

Add release notes for 1.92.0 cc ``@rust-lang/release`` r? ``@BoxyUwU``

Rollup merge of rust-lang#149720 - jtracey:patch-1, r=notriddle

c4778dc

rustdoc book: mention inner doc attribute Couldn't find this documented anywhere else.

Rollup merge of rust-lang#149779 - tbu-:pr_an_false, r=joboet

2fffbb5

Fix typo "an" → "and"

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Dec 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2025

bors merged commit d5525a7 into rust-lang:main Dec 9, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #149798

Rollup of 11 pull requests #149798

matthiaskrgr commented Dec 9, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Rollup of 11 pull requests #149798

Rollup of 11 pull requests #149798

Conversation

matthiaskrgr commented Dec 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Dec 9, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

matthiaskrgr commented Dec 9, 2025 •

edited by rustbot

Loading