Skip to content

compiletest: tidy up adb_path/adb_test_dir handling #149826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jieyouxu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compiletest: tidy up adb_path/adb_test_dir handling #149826

jieyouxu wants to merge 1 commit into from
+13 −11

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Dec 10, 2025

Be more faithful that they aren't always available.

try-job: arm-android

@jieyouxu
compiletest: tidy up adb_path/adb_test_dir handling
fc3d61e 
Be more faithful that they aren't always available.
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 10, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 10, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 10, 2025
@rust-bors
Auto merge of #149826 - jieyouxu:compiletest-adb, r=<try>
ef0a1c4 
compiletest: tidy up `adb_path`/`adb_test_dir` handling

try-job: arm-android
@rust-bors
Copy link

rust-bors bot commented Dec 10, 2025

☀️ Try build successful (CI)
Build commit: ef0a1c4 (ef0a1c435a8fbfff69da3ae57c7754153fa9edd9, parent: 5f1173bb2b0a7012640bd5383c61b433b16a452d)

@jieyouxu jieyouxu marked this pull request as ready for review December 10, 2025 03:56
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 10, 2025
@Zalathar
Copy link
Member

Zalathar commented Dec 10, 2025

Nice.

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 10, 2025

📌 Commit fc3d61e has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 10, 2025
@Zalathar
Rollup merge of rust-lang#149826 - jieyouxu:compiletest-adb, r=Zalathar
5ae893d 
compiletest: tidy up `adb_path`/`adb_test_dir` handling

Be more faithful that they aren't always available.

try-job: arm-android
@Zalathar Zalathar mentioned this pull request Dec 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 10, 2025
@Zalathar
Rollup merge of rust-lang#149826 - jieyouxu:compiletest-adb, r=Zalathar
4490292 
compiletest: tidy up `adb_path`/`adb_test_dir` handling

Be more faithful that they aren't always available.

try-job: arm-android
@Zalathar Zalathar mentioned this pull request Dec 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zalathar Zalathar

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu @rustbot @Zalathar @bors