Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Once again I sign (I still don't know if I have to ?):
Guillaume Gomez : guillaume1.gomez@gmail.com

Once again I sign (I still don't know if I have to ?):
Guillaume Gomez : guillaume1.gomez@gmail.com
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed. Note that on 214, "A crash!" has an exclamation mark to end the sentence, and here, inside the ()s, there's also an exclamation mark to end the sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry ! You're totally right, my bad !

@steveklabnik
Copy link
Contributor

You do not need to sign off on the commits.

Thank you for opening these, even though I'm not accepting this one!

@GuillaumeGomez
Copy link
Member Author

No problem! Thanks for your precision !

@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch January 10, 2015 01:36
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 27, 2025
Migrate `add_braces` assist, because edit_in_place uses ted
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
Migrate `add_braces` assist, because edit_in_place uses ted
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
Migrate `add_braces` assist, because edit_in_place uses ted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants