-
Notifications
You must be signed in to change notification settings - Fork 14k
[r+] Intpocalypse, book edition. #21096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
with respect to the choice of reviewer: No good deed goes unpunished. |
|
@nikomatsakis ❤️ 😅 |
src/doc/trpl/generics.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
error: mismatched types: expected core::option::Option, found core::option::Option<_> (expected f64, found integral variable)
80e8f95 to
45e01b4
Compare
45e01b4 to
b290fbe
Compare
b290fbe to
180efcc
Compare
src/doc/trpl/pointers.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflict markers? 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffuuuu
180efcc to
d3300c0
Compare
Fix all usage of int/uint/i/u in the book.
d3300c0 to
59c75e5
Compare
|
This made it in as part of my rolllup |
Fix all usage of int/uint/i/u in the book.
r? @nikomatsakis who called this to my attention.