Rollup of 17 pull requests #25731
Closed
Rollup of 17 pull requests #25731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
sorry about that :/ i thought it'd create that branch in my repos only. well, now that it's done I'm at least running make check |
|
stage1 passes |
|
make check passes |
|
@bors: r+ p=1 |
|
📌 Commit 251481f has been approved by |
|
@bors: r- |
|
wait a minute, why does this have 17 PRs when theres only seven in the queue that are open? |
|
there are some that are already merged |
|
oh + the rollup PRs |
|
are you on IRC? I'm confused. |
oli-obk
force-pushed
the
rollup
branch
2 times, most recently
from
2b803dc
to
882af3f
Compare
Also, when checking for common gendered words elsewhere, I found one 'he', moved to 'they' as well. rust-lang#25640 (comment)
Took me a moment to figure out that the appropriate response to "need program file" was to install the program named "file", not to think "If I didn't need the program file, why would I be compiling things?".
The `run` function passed its argument to `msg` via `"$@"`, but `msg` only printed its first argument. I think the intention was for `msg` to print all its arguments. (If not, `run` should only `msg "$1"`.)
There are more possible optimizations left (cached length in loops) as well as some possible bugs (shadowed variables) to fix. This is mostly syntactic.
I consider that this version has a better reading fluency, instead of having a period between clauses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
direntpointers #25632, Fix ICE trying to pass DST to C functions #25653, doc: miscellaneous improvements to std::path::Path examples #25666, Fix stability and deprecation markers on soft_link and symlink #25667, she -> [they] in Dining Philosophers #25681, Simplifycore::numusingSelf#25687, Document the debug_assertions cfg option #25695, Two minor friendliness patches to ./configure #25697, Rustdoc search: Increase relevance of primitive types #25702, Lazy-load filemaps from external crates. #25703, better describe the stdlib #25709, Let MultiItemDecorator take&Annotatable#25710, Make it clear that push is only amortized O(1) #25714, Update guessing-game.md #25715, Don't mention outdated methods #25716, allow clang 3.7 to be used when configuring Fixes #25720 #25722