Implement `#[deprecated]` attribute (RFC 1270) #30206

petrochenkov · Dec 4, 2015

The attributes deprecated and rustc_deprecated are completely independent in this implementation and it leads to some noticeable code duplication. Representing deprecated as

Stability {
    level: Stable { since: "" },
    feature: "",
    depr: Some(Deprecation),
}

or, contrariwise, splitting rustc_deprecation from stability makes most of the duplication go away.
I can do this refactoring, but before doing it I must be sure, that further divergence of deprecated and rustc_deprecated is certainly not a goal.

cc @llogiq

rust-highfive · Dec 4, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

llogiq · Dec 4, 2015

Great work, @petrochenkov! I think allowing the features to diverge further was the express intent of the RFC. This means we can use #[rustc_deprecation] as is and iterate on the #[deprecation] feature, e.g. adding other optional fields.

petrochenkov · Dec 4, 2015

I'd prefer the standard library to migrate to #[deprecated] eventually (after its stabilization, for example), maybe with slightly stricter checks, like now. I.e. I see #[rustc_deprecated] as a temporary measure.

brson · Dec 10, 2015

This patch looks quite thorough. Good work.

brson · Dec 10, 2015

brson reviewed Dec 10, 2015

View changes

brson · Dec 10, 2015

src/librustc/middle/stability.rs

+                                               "`#[deprecated]` attribute is unstable");
+                        fileline_help!(self.tcx.sess, attr.span(), "add #![feature(deprecated)] to \
+                                                                    the crate features to enable");
+                    }


This check should probably be in libsyntax/feature_gate.rs

brson · Dec 10, 2015

brson reviewed Dec 10, 2015

View changes

brson · Dec 10, 2015

src/librustc/middle/stability.rs

+                // unmarked impls for it. See FIXME above for more details.
+
+                debug!("lookup: trait_id={:?}", trait_id);
+                return lookup_deprecation(tcx, trait_id);


The duplication of this method strikes me as particularly bad. Can the contents be abstracted into lookup_uncached_generic?

I've removed some obsolete code from these functions instead, should be better now.

brson · Dec 10, 2015

brson reviewed Dec 10, 2015

View changes

brson · Dec 10, 2015

src/librustc_lint/builtin.rs

@@ -577,74 +577,71 @@ impl LateLintPass for MissingDebugImplementations {
 declare_lint! {
    DEPRECATED,
    Warn,
-    "detects use of #[rustc_deprecated] items"
+    "detects use of `#[deprecated]` or `#[rustc_deprecated]` items"


The existence of #[rustc_deprecated] is an implementation detail. Can we change this string to 'detects use of deprecated items'?

brson · Dec 10, 2015

brson reviewed Dec 10, 2015

View changes

brson · Dec 10, 2015

src/test/compile-fail/deprecation-in-staged-api.rs

+
+// #[deprecated] can't be used in staged api
+
+#![feature(deprecated, staged_api)]


Didn't we remove the staged_api feature?

We removed #[staged_api] attribute, not #[feature(staged_api)].
#[feature(staged_api)] gates stability attributes.

brson · Dec 10, 2015

brson reviewed Dec 10, 2015

View changes

brson · Dec 10, 2015

src/test/auxiliary/deprecation-lint.rs

+    fn trait_deprecated(&self) {}
+    #[deprecated(since = "1.0.0", note = "text")]
+    fn trait_deprecated_text(&self) {}
+}


Why isn't there a test with the deprecated attribute on the trait itself?

petrochenkov · Dec 12, 2015

Updated with comments addressed.
I've also added rustdoc support for #[deprecated]. (I intended to avoid doing this initially and merge Deprecation into Stability instead.)

brson · Dec 14, 2015

Huh, this is a surprising patch. Were these four blocks of code in these two lookup_*_uncached methods not actually doing anything useful? Where is this work done now?

All trait impls have annotations now (this work was done in rust-lang#29152 and rust-lang#29083), so there's no need to infer them from annotations on traits.
But this is not important anyway, because annotations on trait impls are not currently used during checking phase and serve only as documentation.

brson · Dec 15, 2015

@bors r+

bors · Dec 15, 2015

📌 Commit 67a9784 has been approved by brson

bors · Dec 16, 2015

⌛️ Testing commit 67a9784 with merge ac2c5ff...

bors · Dec 16, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

durka · Dec 22, 2015

Is there a reason (heh) that this was implemented with #[deprecated(note = "...")] instead of #[deprecated(reason = "...")] as in the RFC? Should we amend the RFC to match (the rename was mentioned as an alternative but not in the main text)?

petrochenkov · Dec 22, 2015

@durka

Is there a reason (heh) that this was implemented with #[deprecated(note = "...")] instead of #[deprecated(reason = "...")] as in the RFC?

Yes, by request from the RFC author, also see rust-lang/rfcs#1270 (comment)
RFC should really be amended since it's the central piece of documentation about this feature at the moment.

liigo · Dec 23, 2015

I'm surprised. Implementation violate the RFC (note VS reason) intentionally without any reason, and surprised that was merged without any query. I don't oppose note (I like it), I just obey the RFC.

(This is not the first time i noticed that RFC was violated by intention. Please respect RFC! Please amend RFC first if you think there is an error.)

llogiq · Dec 23, 2015

I'm a bit busy ATM but will push a PR to change the RFC shortly to alleviate the situation.

llogiq · Dec 23, 2015

See RFC PR #1425

durka · Dec 23, 2015

Oops, I had already submitted the same PR at rust-lang/rfcs#1423. @liigo your language is a bit stronger than necessary since this decision was essentially made in the RFC thread as it was being accepted, but just didn't make it into the text on time.

liigo · Dec 24, 2015

since this decision was essentially made in the RFC thread

I don't think so. Only three people says "note seems fine", no consensus, no confirmed by the libs (or lang) team.

When RFC 1270 was merging, Alex said:

we can always tweak minor details like naming here and there after this is merged

That is, note was not accepted yet at that time.

llogiq · Dec 24, 2015

It isn't unusual to tweak details in the implementation after an RFC is accepted. Please forgive my cavalier attitude, but I don't think changing a field name on an unstable attribute requires the whole teams' consenus.

petrochenkov · Dec 24, 2015

I've just noticed, this is not marked with "relnotes", but probably should be.

bluss · Jan 11, 2016

Is there a tracking issue for stabilization?

rust-highfive assigned brson Dec 4, 2015

petrochenkov added some commits Dec 4, 2015

Implement `#[deprecated]` attribute (RFC 1270)

e3ed7b0

Address the review comments

105bd15

Support `#[deprecated]` in rustdoc

Loading status checks…

67a9784

petrochenkov force-pushed the petrochenkov:newdepr branch from aebbae0 to 67a9784 Dec 12, 2015

bors merged commit 67a9784 into rust-lang:master Dec 16, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

This was referenced Dec 16, 2015

Closed

Improve OwnedSlice and use it in HIR #30095

Merged

Refactor error handling #30384

Merged

Partially implement type ascription #30184

durka referenced this pull request Dec 22, 2015
Merged
Amend RFC 1270 to describe actual implementation #1423

bluss added the relnotes label Jan 11, 2016

petrochenkov deleted the petrochenkov:newdepr branch Sep 21, 2016

kennytm referenced this pull request Aug 20, 2017
Merged
use gcc::Build rather than deprecated gcc::Config #43975

rust-lang/rust

Join GitHub today

Implement `#[deprecated]` attribute (RFC 1270) #30206

Conversation

petrochenkov commented Dec 4, 2015

rust-highfive assigned brson Dec 4, 2015

This comment has been minimized.

rust-highfive commented Dec 4, 2015

This comment has been minimized.

llogiq commented Dec 4, 2015

This comment has been minimized.

petrochenkov commented Dec 4, 2015

This comment has been minimized.

brson commented Dec 10, 2015

brson reviewed Dec 10, 2015 View changes

This comment has been minimized.

brson reviewed Dec 10, 2015 View changes

This comment has been minimized.

This comment has been minimized.

brson reviewed Dec 10, 2015 View changes

This comment has been minimized.

brson reviewed Dec 10, 2015 View changes

This comment has been minimized.

This comment has been minimized.

brson reviewed Dec 10, 2015 View changes

This comment has been minimized.

petrochenkov added some commits Dec 4, 2015

petrochenkov force-pushed the petrochenkov:newdepr branch from aebbae0 to 67a9784 Dec 12, 2015

This comment has been minimized.

petrochenkov commented Dec 12, 2015

This comment has been minimized.

brson commented on src/librustc/middle/stability.rs in 105bd15 Dec 14, 2015

This comment has been minimized.

petrochenkov replied Dec 14, 2015

This comment has been minimized.

brson commented Dec 15, 2015

This comment has been minimized.

bors commented Dec 15, 2015

This comment has been minimized.

bors commented Dec 16, 2015

bors added a commit that referenced this pull request Dec 16, 2015

This comment has been minimized.

bors commented Dec 16, 2015

Hide details View details bors merged commit 67a9784 into rust-lang:master Dec 16, 2015 2 checks passed

2 checks passed

This was referenced Dec 16, 2015

This comment has been minimized.

durka commented Dec 22, 2015

This comment has been minimized.

petrochenkov commented Dec 22, 2015

durka referenced this pull request Dec 22, 2015

This comment has been minimized.

liigo commented Dec 23, 2015

This comment has been minimized.

llogiq commented Dec 23, 2015

This comment has been minimized.

llogiq commented Dec 23, 2015

This comment has been minimized.

durka commented Dec 23, 2015

This comment has been minimized.

liigo commented Dec 24, 2015

This comment has been minimized.

llogiq commented Dec 24, 2015

This comment has been minimized.

petrochenkov commented Dec 24, 2015

bluss added the relnotes label Jan 11, 2016

This comment has been minimized.

bluss commented Jan 11, 2016

petrochenkov deleted the petrochenkov:newdepr branch Sep 21, 2016

kennytm referenced this pull request Aug 20, 2017

brson reviewed Dec 10, 2015

View changes

brson reviewed Dec 10, 2015

View changes

brson reviewed Dec 10, 2015

View changes

brson reviewed Dec 10, 2015

View changes

brson reviewed Dec 10, 2015

View changes

petrochenkov force-pushed the petrochenkov:newdepr branch from `aebbae0` to `67a9784` Dec 12, 2015

brson commented on `src/librustc/middle/stability.rs` in `105bd15` Dec 14, 2015

bors merged commit `67a9784` into rust-lang:master Dec 16, 2015
2 checks passed