Skip to content

Builder docs #38491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2016
Merged

Builder docs #38491

merged 1 commit into from
Dec 30, 2016

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Contributor

tidy reports trailing whitespace (see Travis).

@GuillaumeGomez
Copy link
Member Author

It seems it wasn't me. Some commits have added. I rebased.

frewsxcv
frewsxcv reviewed Dec 21, 2016
View reviewed changes
src/libstd/thread/mod.rs
///
/// ```
/// use std::thread;
///
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's trailing whitespace on this line for example:

+    ///

@GuillaumeGomez
Copy link
Member Author

Updated.

@frewsxcv
Copy link
Contributor

There's still trailing whitespace. See Travis.

@GuillaumeGomez
Copy link
Member Author

Updated again.

frewsxcv
frewsxcv reviewed Dec 23, 2016
View reviewed changes
src/libstd/thread/mod.rs
/// ```
/// use std::thread;
///
/// let builder = thread::Builder::new();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon should be removed here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, good catch!

@GuillaumeGomez
Copy link
Member Author

Updated!

@frewsxcv
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 24, 2016

📌 Commit 292d36f has been approved by frewsxcv

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016
@alexcrichton
Rollup merge of rust-lang#38491 - GuillaumeGomez:builder_docs, r=frew…
26f28ec 
…sxcv

Builder docs

r? @frewsxcv
@alexcrichton alexcrichton mentioned this pull request Dec 30, 2016
Merged
bors added a commit that referenced this pull request Dec 30, 2016
@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton
7f2d2af 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
@bors bors merged commit 292d36f into rust-lang:master Dec 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the builder_docs branch December 30, 2016 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@frewsxcv frewsxcv frewsxcv left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @frewsxcv @bors