Issue 3148 #4628
Closed
Issue 3148 #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contents of other borrowed pointers to the lifetimes of the borrowed value. Fixes rust-lang#3148.
The tail portion of the pattern effectively borrows a vector, but the borrow checker knew nothing about this.
for notating FIXME-style-situations that you want to be reminded of before you commit.
|
r+ but I pointed out a few places in the comments in 01bf87e where they could be clearer. I appreciate all the comments, and want to make sure they're as useful as possible! |
|
ok, thanks for the suggestions tim. |
|
Pushed. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 15, 2025
native-lib: support all types with Scalar layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3148, which is that the lifetimes of borrowed pointers are sometimes inferred to be too small. Also fix the borrow checker's treatment of vec patterns, which was completely absent.
Finally, add an option to tidy so you can leave "// WARN" comments in your code that will be printed out. This is useful for putting notes to yourself of things that are not done.
r? @catamorphism