Rollup of 14 pull requests #54944
Closed
Rollup of 14 pull requests #54944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarification of the use of `ptr::eq` to test equality of references via address by pointer coercion
…g` setting in `Cargo.toml`.
This commit enhances `LaterUseKind` detection to identify when a borrow is captured by a trait object which helps explain why there is a borrow error.
This commit updates the captured trait object search logic to look for unsized casts to boxed types rather than for functions that returned trait objects.
This commit adds suggestions to change the definitions of fields in struct definitions from immutable references to mutable references.
This commit changes the label to a maybe incorrect suggestion for better integration with RLS.
and to briefly touch on the theory of debugging rustc versus the practice of such.
…ss-eq, r=QuietMisdreavus Documents reference equality by address (rust-lang#54197) Clarification of the use of `ptr::eq` to test equality of references via address by pointer coercion, regarding issue rust-lang#54197 . The same example as in `ptr::eq` docs is shown here to clarify that `PartialEq` compares values pointed-to instead of via address (which can be desired in some cases)
…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840
…suggestion, r=nikomatsakis NLL is missing struct field suggestion Part of rust-lang#52663. This commit adds suggestions to change the definitions of fields in struct definitions from immutable references to mutable references. r? @nikomatsakis cc @pnkfelix
… r=nikomatsakis Better Diagnostic for Trait Object Capture Part of rust-lang#52663. This commit enhances `LaterUseKind` detection to identify when a borrow is captured by a trait object which helps explain why there is a borrow error. r? @nikomatsakis cc @pnkfelix
…m-macro, r=nikomatsakis Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Previously parsing trait items only handled opening brace token and semicolon, I added a branch to the match statement that will also handle interpolated blocks.
Add doc comments about safest way to initialize a vector of zeros This adds more information about the vec! macro as discussed in rust-lang#54628. I think this is a good starting point, but I think additional detail is needed so that we can explain why vec! is safer than the alternatives.
…uietMisdreavus Fix mobile docs Fixes rust-lang#54836. <img width="1440" alt="screen shot 2018-10-06 at 18 53 19" src="https://user-images.githubusercontent.com/3050060/46573683-1b4cd700-c999-11e8-9e6b-86a23b332e22.png"> r? @QuietMisdreavus
Fix tracking issue for Once::is_completed rust-lang#53027 was merged without a tracking issue. I just filed rust-lang#54890. CC @matklad
Fix internal compiler error on malformed match arm pattern. Issue: rust-lang#54379
…, r=Centril Stabilize the `Option::replace` method This PR stabilize the `Option::replace` method propose in rust-lang#51998.
doc fix: it's auto traits that make for automatic implementations Being a marker trait is not good enough (that just means "no items in the trait"). r? @alexcrichton who [originally wrote these docs](RalfJung@0a13f1a).
Unused result warning: "X which must" ↦ "X that must" Address a little grammatical faux pas in the unused result warning.
Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.
impl Eq+Hash for TyLayout As proposed by @eddyb at rust-lang#53671 (review). I have an upcoming PR that would also significantly benefit from this.
|
@bors r+ p=14 |
|
📌 Commit ec1b889 has been approved by |
bors
added
the
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
⌛ Testing commit ec1b889 with merge c8a9342382541e4daff3970f57a79120be79f4ae... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
optimizeindependent ofdebug#54811 (During rustc bootstrap, make default foroptimizeindependent ofdebug);or{, found{ ... }#54707 - parse_trait_item_ now handles interpolated blocks as function body decls)Option::replacemethod #54904 (Stabilize theOption::replacemethod)Failed merges:
r? @ghost