New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryFrom<&[T]> for [T; $N] where T: Copy #56216

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@SimonSapin
Contributor

SimonSapin commented Nov 25, 2018

TryFrom<&[T]> for &[T; $N] (note reference to an array) already exists, but not needing to dereference makes type inference easier for example when using u32::from_be_bytes.

Also add doc examples doing just that.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Nov 25, 2018

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Nov 25, 2018

This will conflict with #56207, I’ll rebase when that lands.

@withoutboats

This comment has been minimized.

Contributor

withoutboats commented Nov 25, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 25, 2018

📌 Commit 8281de4 has been approved by withoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy
`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists,
but not needing to dereference makes type inference easier
for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

@SimonSapin SimonSapin force-pushed the SimonSapin:array-tryfrom-slice branch from 8281de4 to 057e6d3 Nov 25, 2018

@SimonSapin

This comment has been minimized.

Contributor

SimonSapin commented Nov 25, 2018

Removed #![feature] in doc tests for feature stabilized in #56207.

@bors r=withoutboats

@bors

This comment has been minimized.

Contributor

bors commented Nov 25, 2018

📌 Commit 057e6d3 has been approved by withoutboats

kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

bors added a commit that referenced this pull request Nov 27, 2018

Auto merge of #56276 - kennytm:rollup, r=kennytm
Rollup of 9 pull requests

Successful merges:

 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56114 (Enclose type in backticks for "non-exhaustive patterns" error)
 - #56127 (Update an outdated comment in mir building)
 - #56205 (Fix ICE with feature self_struct_ctor)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56223 (Make JSON output from -Zprofile-json valid)
 - #56224 (Update cargo)
 - #56236 (Remove unsafe `unsafe` inner function.)
 - #56255 (Update outdated code comments in StringReader)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 28, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 28, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

bors added a commit that referenced this pull request Nov 28, 2018

Auto merge of #56325 - pietroalbini:rollup, r=pietroalbini
Rollup of 29 pull requests

Successful merges:

 - #55391 (bootstrap: clean up a few clippy findings)
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56021 (avoid features_untracked)
 - #56023 (atomic::Ordering: Get rid of misleading parts of intro)
 - #56044 (Drop partially bound function parameters in the expected order)
 - #56080 (Reduce the amount of bold text at doc.rlo)
 - #56090 (Overhaul `FileSearch` and `SearchPaths`)
 - #56114 (Enclose type in backticks for "non-exhaustive patterns" error)
 - #56124 (Fix small doc mistake on std::io::read::read_to_end)
 - #56127 (Update an outdated comment in mir building)
 - #56131 (Assorted tweaks)
 - #56148 (Add rustc-guide as a submodule)
 - #56149 (Make std::os::unix/linux::fs::MetadataExt::a/m/ctime* documentation clearer)
 - #56165 (drop glue takes in mutable references, it should reflect that in its type)
 - #56205 (Fix ICE with feature self_struct_ctor)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56220 (Suggest appropriate place for lifetime when declared after type arguments)
 - #56223 (Make JSON output from -Zprofile-json valid)
 - #56236 (Remove unsafe `unsafe` inner function.)
 - #56245 (Stabilize feature `macro_at_most_once_rep`)
 - #56255 (Update outdated code comments in StringReader)
 - #56257 (rustc-guide has moved to rust-lang/)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56273 (Add missing doc link)
 - #56285 (move stage0.txt to toplevel directory)
 - #56289 (Fix small typo in comment of thread::stack_size)
 - #56294 (Fix a typo in the documentation of std::ffi)
 - #56300 (Fix alignment of stores to scalar pair)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 29, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

bors added a commit that referenced this pull request Nov 30, 2018

Auto merge of #56353 - pietroalbini:rollup, r=pietroalbini
Rollup of 11 pull requests

Successful merges:

 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56165 (drop glue takes in mutable references, it should reflect that in its type)
 - #56205 (Fix ICE with feature self_struct_ctor)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56258 (use top level `fs` functions where appropriate)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)

Failed merges:

 - #56285 (move stage0.txt to toplevel directory)

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

bors added a commit that referenced this pull request Nov 30, 2018

Auto merge of #56376 - kennytm:rollup, r=kennytm
Rollup of 16 pull requests

Successful merges:

 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56224 (Update cargo)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56285 (move stage0.txt to toplevel directory)
 - #56305 (update miri)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56373 (Update books)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

Rollup merge of rust-lang#56216 - SimonSapin:array-tryfrom-slice, r=w…
…ithoutboats

Add TryFrom<&[T]> for [T; $N] where T: Copy

`TryFrom<&[T]> for &[T; $N]` (note *reference* to an array) already exists, but not needing to dereference makes type inference easier for example when using `u32::from_be_bytes`.

Also add doc examples doing just that.

bors added a commit that referenced this pull request Nov 30, 2018

Auto merge of #56381 - kennytm:rollup, r=kennytm
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)

@bors bors merged commit 057e6d3 into rust-lang:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment