New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize self_struct_ctor feature. #56365

Merged
merged 5 commits into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@alexreg
Contributor

alexreg commented Nov 30, 2018

@alexreg alexreg force-pushed the alexreg:stabilise-self_struct_ctor branch 2 times, most recently from c10ed56 to 3f28e7e Nov 30, 2018

@Centril

Looks good; thanks!

@Centril

This comment has been minimized.

Contributor

Centril commented Nov 30, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 30, 2018

📌 Commit 3f28e7e has been approved by Centril

@rust-highfive

This comment was marked as resolved.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1cb04f98:start=1543548113230384832,finish=1543548115587252914,duration=2356868082
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/aa/e5/ebd5896ad5ae353d23bea05ebb8edd3d49f1471784f6afa12a9cf11710de/awscli-1.16.67-py2.py3-none-any.whl (1.4MB)
    0% |▎                               | 10kB 11.8MB/s eta 0:00:01
    1% |▌                               | 20kB 1.3MB/s eta 0:00:02
    2% |▊                               | 30kB 1.7MB/s eta 0:00:01
    2% |█                               | 40kB 1.6MB/s eta 0:00:01
---
[00:04:57]    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
[00:05:02]    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
[00:06:25]    Compiling proc_macro v0.0.0 (/checkout/src/libproc_macro)
[00:06:35]    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[00:06:40] error: unused imports: `GateIssue`, `emit_feature_err`
[00:06:40]   --> src/librustc/hir/lowering.rs:70:28
[00:06:40]    |
[00:06:40] 70 | use syntax::feature_gate::{emit_feature_err, GateIssue};
[00:06:40]    |
[00:06:40]    = note: `-D unused-imports` implied by `-D warnings`
[00:06:40] 
travis_time:end:023ee024:start=1543548552027569339,finish=1543548552033843704,duration=6274365
---
travis_time:end:281cd3bd:start=1543548552039093522,finish=1543548552044566912,duration=5473390
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0be58efc
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05ae0524
travis_time:start:05ae0524
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:stabilise-self_struct_ctor branch from 3f28e7e to 31db25d Nov 30, 2018

@Centril

This comment has been minimized.

Contributor

Centril commented Nov 30, 2018

Let's try again;
@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 30, 2018

📌 Commit 31db25d has been approved by Centril

@rust-highfive

This comment was marked as outdated.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0d7e75ea:start=1543549068915637338,finish=1543549071107749173,duration=2192111835
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/aa/e5/ebd5896ad5ae353d23bea05ebb8edd3d49f1471784f6afa12a9cf11710de/awscli-1.16.67-py2.py3-none-any.whl (1.4MB)
    0% |▎                               | 10kB 19.7MB/s eta 0:00:01
    1% |▌                               | 20kB 1.9MB/s eta 0:00:01
    2% |▊                               | 30kB 2.2MB/s eta 0:00:01
    2% |█                               | 40kB 2.0MB/s eta 0:00:01
---
[00:47:52] .................................................................................................... 1100/5066
[00:47:54] .................................................................................................... 1200/5066
[00:47:56] .................................................................................................... 1300/5066
[00:47:59] .................................................................................................... 1400/5066
[00:48:01] ..............................................................................F..................... 1500/5066
[00:48:08] .................................................................................................... 1700/5066
[00:48:11] .................................................................................................... 1800/5066
[00:48:15] .................................................................................................... 1900/5066
[00:48:18] ...........................i........................................................................ 2000/5066
---
[00:48:37] .................................................................................................... 2500/5066
[00:48:41] .................................................................................................... 2600/5066
[00:48:45] .................................................................................................... 2700/5066
[00:48:48] .................................................................................................... 2800/5066
[00:48:51] ......................................................F............................................. 2900/5066
[00:48:59] ......................................................................i............................. 3100/5066
[00:49:02] .................................................................................................... 3200/5066
[00:49:05] .................................ii..i..ii.......................................................... 3300/5066
[00:49:09] .................................................................................................... 3400/5066
---
[00:49:23] .................................................................................................... 4000/5066
[00:49:26] .................................................................................................... 4100/5066
[00:49:29] .................................................................................................... 4200/5066
[00:49:33] .................................................i.................................................. 4300/5066
[00:49:39] ...................................................................................F................ 4400/5066
[00:49:45] .................................................................................................... 4600/5066
[00:49:49] ..............................i..................................................................... 4700/5066
[00:49:53] .................................................................................................... 4800/5066
[00:49:56] .................................................................................................... 4900/5066
[00:49:56] .................................................................................................... 4900/5066
:00] -    |
[00:50:00] -    = help: add #![feature(self_struct_ctor)] to the crate attributes to enable
[00:50:00] + error: aborting due to 4 previous errors
[00:50:00] 32 
[00:50:00] - error[E0658]: `Self` struct constructors are unstable (see issue #51994)
[00:50:00] -    |
[00:50:00] -    |
[00:50:00] - LL |         Self => (),
[00:50:00] -    |
[00:50:00] -    |
[00:50:00] -    = help: add #![feature(self_struct_ctor)] to the crate attributes to enable
[00:50:00] - 
[00:50:00] - error[E0658]: `Self` struct constructors are unstable (see issue #51994)
[00:50:00] -    |
[00:50:00] -    |
[00:50:00] - LL |         Foo { x: Self } => (),
[00:50:00] -    |
[00:50:00] -    |
[00:50:00] -    = help: add #![feature(self_struct_ctor)] to the crate attributes to enable
[00:50:00] - error: aborting due to 7 previous errors
[00:50:00] - 
[00:50:00] - Some errors occurred: E0432, E0531, E0658.
[00:50:00] + Some errors occurred: E0432, E0531.
[00:50:00] + Some errors occurred: E0432, E0531.
[00:50:00] 52 For more information about an error, try `rustc --explain E0432`.
[00:50:00] 53 
[00:50:00] 
[00:50:00] 
[00:50:00] The actual stderr differed from the expected stderr.
[00:50:00] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/self/self_type_keyword-2/self_type_keyword-2.stderr
[00:50:00] To update references, rerun the tests and pass the `--bless` flag
[00:50:00] To only update this specific test, also pass `--test-args self/self_type_keyword-2.rs`
[00:50:00] 
[00:50:00] error: 1 errors occurred comparing ode":{"code":"E0531","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/self/self_type_keyword-2.rs","byte_start":745,"byte_end":749,"line_start":19,"line_end":19,"column_start":9,"column_end":13,"is_primary":true,"text":[{"text":"        Self => (),","highlight_start":9,"highlight_end":13}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/self/self_type_keyword-2.rs:19:9\n   |\nLL |         Self => (),\n   |         ^^^^ not found in this scope\n\n"}
[00:50:00] {"message":"cannot find unit struct/variant or constant `Self` in this scope","code":{"code":"E0531","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/self/self_type_keyword-2.rs","byte_start":937,"byte_end":941,"line_start":22,"line_end":22,"column_start":18,"column_end":22,"is_primary":true,"text":[{"text":"        Foo { x: Self } => (),","highlight_start":18,"highlight_end":22}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/self/self_type_keyword-2.rs:22:18\n   |\nLL |         Foo { x: Self } => (),\n   |                  ^^^^ not found in this scope\n\n"}
[00:50:00] {"message":"aborting due to 4 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 4 previous

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the relnotes label Nov 30, 2018

@alexreg alexreg force-pushed the alexreg:stabilise-self_struct_ctor branch from 31db25d to dcd512f Nov 30, 2018

@Centril

Looks good; but let's wait on tests to pass first to be sure. :)

@rust-highfive

This comment was marked as resolved.

Collaborator

rust-highfive commented Nov 30, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:01de1e88:start=1543553526219730636,finish=1543553528589920223,duration=2370189587
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:46:39] .................................................................................................... 2500/5065
[00:46:42] .................................................................................................... 2600/5065
[00:46:46] .................................................................................................... 2700/5065
[00:46:50] .................................................................................................... 2800/5065
[00:46:52] .....................................................F.............................................. 2900/5065
[00:46:59] .....................................................................i.............................. 3100/5065
[00:47:02] .................................................................................................... 3200/5065
[00:47:05] ................................ii..i..ii........................................................... 3300/5065
[00:47:09] .................................................................................................... 3400/5065
---
[00:47:22] .................................................................................................... 4000/5065
[00:47:24] .................................................................................................... 4100/5065
[00:47:27] .................................................................................................... 4200/5065
[00:47:31] ................................................i................................................... 4300/5065
[00:47:36] .................................................................................F.................. 4400/5065
[00:47:42] .................................................................................................... 4600/5065
[00:47:45] .............................i...................................................................... 4700/5065
[00:47:49] .................................................................................................... 4800/5065
[00:47:52] .................................................................................................... 4900/5065
[00:47:52] .................................................................................................... 4900/5065
[00:47:54] .................................................................................................... 5000/5065
"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/keyword/keyword-self-as-identifier.rs:12:9\n   |\nLL |     let Self = 22; //~ ERROR cannot find unit struct/variant or constant `Self` in this scope\n   |         ^^^^ not found in this scope\n\n"}
[00:47:56] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:47:56] {"message":"For more information about this error, try `rustc --explain E0531`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0531`.\n"}
[00:47:56] ------------------------------------------
[00:47:56] 
[00:47:56] thread '[ui] ui/keyword/keyword-self-as-identifier.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:47:56] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:47:56] 29 
[00:47:56] 
[00:47:56] 
[00:47:56] The actual stderr differed from the expected stderr.
[00:47:56] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/self/self_type_keyword-2/self_type_keyword-2.stderr
[00:47:56] To update references, rerun the tests and pass the `--bless` flag
[00:47:56] To only update this specific test, also pass `--test-args self/self_type_keyword-2.rs`
[00:47:56] error: 1 errors occurred comparing output.
[00:47:56] status: exit code: 1
[00:47:56] status: exit code: 1
[00:47:56] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/self/self_type_keyword-2.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/self/self_type_keyword-2/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/self/self_type_keyword-2/auxiliary" "-A" "unused"
[00:47:56] ------------------------------------------
[00:47:56] 
[00:47:56] ------------------------------------------
[00:47:56] stderr:
[00:47:56] stderr:
[00:47:56] ------------------------------------------
[00:47:56] {"message":"unresolved import `self::Self`","code":{"code":"E0432","explanation":"\nAn import was unresolved.\n\nErroneous code example:\n\n```compile_fail,E0432\nuse something::Foo; // error: unresolved import `something::Foo`.\n```\n\nPaths in `use` statements are relative to the crate root. To import items\nrelative to the current and parent modules, use the `self::` and `super::`\nprefixes, respectively. Also verify that you didn't misspell the import\nname and that the import ex":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/self/self_type_keyword-2.rs:14:9\n   |\nLL |     let Self = 5;\n   |         ^^^^ not found in this scope\n\n"}
[00:47:56] {"message":"cannot find unit struct/variant or constant `Self` in this scope","code":{"code":"E0531","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/self/self_type_keyword-2.rs","byte_start":670,"byte_end":674,"line_start":18,"line_end":18,"column_start":9,"column_end":13,"is_primary":true,"text":[{"text":"        Self => (),","highlight_start":9,"highlight_end":13}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/self/self_type_keyword-2.rs:18:9\n   |\nLL |         Self => (),\n   |         ^^^^ not found in this scope\n\n"}
[00:47:56] {"message":"cannot find unit struct/variant or constant `Self` in this scope","code":{"code":"E0531","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/self/self_type_keyword-2.rs","byte_start":783,"byte_end":787,"line_start":20,"line_end":20,"column_start":18,"column_end":22,"is_primary":true,"text":[{"text":"        Foo { x: Self } => (),","highlight_start":18,"highlight_end":22}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0531]: cannot find unit struct/variant or constant `Self` in this scope\n  --> /checkout/src/test/ui/self/self_type_keyword-2.rs:20:18\n   |\nLL |         Foo { x: Self } => (),\n   |                  ^^^^ not found in this scope\n\n"}
[00:47:56] {"message":"aborting due to 4 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 4 previous errors\n\n"}
[00:47:56] {"message":"Some errors occurred: E0432, E0531.","code":null,"level":"","spans":[],"children":[],"rendered":"Some errors occurred: E0432, E0531.\n"}
[00:47:56] {"message":"For more information about an error, try `rustc --explain E0432`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about an error, try `rustc --explain E0432`.\n"}
[00:47:56] ------------------------------------------
[00:47:56] 
[00:47:56] thread '[ui] ui/self/self_type_keyword-2.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:47:56] 
---
[00:47:56] 
[00:47:56] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:503:22
[00:47:56] 
[00:47:56] 
[00:47:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:47:56] 
[00:47:56] 
[00:47:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:47:56] Build completed unsuccessfully in 0:03:41
[00:47:56] Build completed unsuccessfully in 0:03:41
[00:47:56] Makefile:58: recipe for target 'check' failed
[00:47:56] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:33f8fa60
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Nov 30 05:40:13 UTC 2018

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexreg alexreg force-pushed the alexreg:stabilise-self_struct_ctor branch from dcd512f to e89ca72 Nov 30, 2018

@alexreg alexreg force-pushed the alexreg:stabilise-self_struct_ctor branch from e89ca72 to 24717fd Nov 30, 2018

@Centril

This comment has been minimized.

Contributor

Centril commented Nov 30, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 30, 2018

📌 Commit 24717fd has been approved by Centril

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

Rollup merge of rust-lang#56365 - alexreg:stabilise-self_struct_ctor,…
… r=Centril

Stabilize self_struct_ctor feature.

[**Tracking Issue**](rust-lang#51994)

kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018

Rollup merge of rust-lang#56365 - alexreg:stabilise-self_struct_ctor,…
… r=Centril

Stabilize self_struct_ctor feature.

[**Tracking Issue**](rust-lang#51994)

bors added a commit that referenced this pull request Nov 30, 2018

Auto merge of #56381 - kennytm:rollup, r=kennytm
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)

@bors bors merged commit 24717fd into rust-lang:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment