Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `repr(transparent)` to `IoSliceMut` where missing #63013

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@nivkner
Copy link
Contributor

commented Jul 26, 2019

tried using IoSliceMut in FFI, got improper_ctypes warning.

according to the docs: IoSliceMut is "guaranteed to be ABI compatible with the iovec type" so it should be usable in FFI.
IoSlice is also repr(transparent) for every platform where these types contain iovec-like types.
vxworks also has IoSliceMut as transparent so its not even consistently one or the other.

no comment about this next to the types or in the PR that introduced the types, so assuming this was just missed.

r? @sfackler

@sfackler

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

📌 Commit d7b2110 has been approved by sfackler

Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Rollup merge of rust-lang#63013 - nivkner:ffi-safe-slice, r=sfackler
add `repr(transparent)` to `IoSliceMut` where missing

tried using `IoSliceMut` in FFI, got `improper_ctypes` warning.

according to the docs: `IoSliceMut` is  "guaranteed to be ABI compatible with the `iovec` type" so it should be usable in FFI.
`IoSlice` is also `repr(transparent)` for every platform where these types contain `iovec`-like types.
vxworks also has `IoSliceMut` as transparent so its not even consistently one or the other.

no comment about this next to the types or in the PR that introduced the types, so assuming this was just missed.

r? @sfackler
bors added a commit that referenced this pull request Jul 26, 2019
Auto merge of #63025 - Centril:rollup-10kfdv9, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #61207 (Allow lifetime elision in `Pin<&(mut) Self>`)
 - #62771 (Break dependencies between `syntax_ext` and other crates)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost
bors added a commit that referenced this pull request Jul 26, 2019
Auto merge of #63025 - Centril:rollup-10kfdv9, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #61207 (Allow lifetime elision in `Pin<&(mut) Self>`)
 - #62771 (Break dependencies between `syntax_ext` and other crates)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Rollup merge of rust-lang#63013 - nivkner:ffi-safe-slice, r=sfackler
add `repr(transparent)` to `IoSliceMut` where missing

tried using `IoSliceMut` in FFI, got `improper_ctypes` warning.

according to the docs: `IoSliceMut` is  "guaranteed to be ABI compatible with the `iovec` type" so it should be usable in FFI.
`IoSlice` is also `repr(transparent)` for every platform where these types contain `iovec`-like types.
vxworks also has `IoSliceMut` as transparent so its not even consistently one or the other.

no comment about this next to the types or in the PR that introduced the types, so assuming this was just missed.

r? @sfackler
bors added a commit that referenced this pull request Jul 26, 2019
Auto merge of #63028 - Centril:rollup-1jekkw7, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #62086 (Define built-in macros through libcore)
 - #62550 (Implement RFC 2707 + Parser recovery for range patterns)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 27, 2019
Rollup merge of rust-lang#63013 - nivkner:ffi-safe-slice, r=sfackler
add `repr(transparent)` to `IoSliceMut` where missing

tried using `IoSliceMut` in FFI, got `improper_ctypes` warning.

according to the docs: `IoSliceMut` is  "guaranteed to be ABI compatible with the `iovec` type" so it should be usable in FFI.
`IoSlice` is also `repr(transparent)` for every platform where these types contain `iovec`-like types.
vxworks also has `IoSliceMut` as transparent so its not even consistently one or the other.

no comment about this next to the types or in the PR that introduced the types, so assuming this was just missed.

r? @sfackler
bors added a commit that referenced this pull request Jul 27, 2019
Auto merge of #63030 - Mark-Simulacrum:rollup-3yw3i09, r=Mark-Simulacrum
Rollup of 5 pull requests

Successful merges:

 - #62392 (Update minifier-rs version)
 - #62550 (Implement RFC 2707 + Parser recovery for range patterns)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019
Rollup merge of rust-lang#63013 - nivkner:ffi-safe-slice, r=sfackler
add `repr(transparent)` to `IoSliceMut` where missing

tried using `IoSliceMut` in FFI, got `improper_ctypes` warning.

according to the docs: `IoSliceMut` is  "guaranteed to be ABI compatible with the `iovec` type" so it should be usable in FFI.
`IoSlice` is also `repr(transparent)` for every platform where these types contain `iovec`-like types.
vxworks also has `IoSliceMut` as transparent so its not even consistently one or the other.

no comment about this next to the types or in the PR that introduced the types, so assuming this was just missed.

r? @sfackler
bors added a commit that referenced this pull request Jul 27, 2019
Auto merge of #63043 - Centril:rollup-f4baee4, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #62423 (Fix cycle error with existential types)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #62982 (Don't access a static just for its size and alignment)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)
 - #63036 (Add lib section to rustc_lexer's Cargo.toml)

Failed merges:

r? @ghost

@bors bors merged commit d7b2110 into rust-lang:master Jul 27, 2019

4 checks passed

pr Build #20190726.62 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.