Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib section to rustc_lexer's Cargo.toml #63036

Merged
merged 2 commits into from Jul 27, 2019

Conversation

@topecongiro
Copy link
Contributor

commented Jul 27, 2019

This is required to fix the rustc-ap-syntax build error in the recent version. The error could also be fixed on the rustc-auto-publish side by manually adding [lib] section if one does not exist. The latter approach, however, may have a surprising side effect, so I am opting for a simpler solution for now.

r? @alexcrichton


[lib]
doctest = false
name = "rustc_lexer"

This comment has been minimized.

Copy link
@matklad

matklad Jul 27, 2019

Member

Could you add a comment explaining that we need this "no-op" lib section for purely for ap?

This comment has been minimized.

Copy link
@topecongiro

topecongiro Jul 27, 2019

Author Contributor

Added a comment in 98f29f5.

@matklad

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

r? @matklad

r=me with an explanatory comment

@Xanewok

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

@bors r=matklad p=2 (blocks RLS update and Rustfmt/Racer nightly builds)

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

📌 Commit 98f29f5 has been approved by matklad

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

⌛️ Testing commit 98f29f5 with merge 0ee6ce7...

bors added a commit that referenced this pull request Jul 27, 2019
Auto merge of #63036 - topecongiro:add-lib-section, r=matklad
Add lib section to rustc_lexer's Cargo.toml

This is required to fix the rustc-ap-syntax build error in the recent version. The error could also be fixed on the [rustc-auto-publish](https://github.com/alexcrichton/rustc-auto-publish) side by manually adding `[lib]` section if one does not exist. The latter approach, however, may have a surprising side effect, so I am opting for a simpler solution for now.

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019
Rollup merge of rust-lang#63036 - topecongiro:add-lib-section, r=matklad
Add lib section to rustc_lexer's Cargo.toml

This is required to fix the rustc-ap-syntax build error in the recent version. The error could also be fixed on the [rustc-auto-publish](https://github.com/alexcrichton/rustc-auto-publish) side by manually adding `[lib]` section if one does not exist. The latter approach, however, may have a surprising side effect, so I am opting for a simpler solution for now.

r? @alexcrichton
@Centril

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Jul 27, 2019
Auto merge of #63043 - Centril:rollup-f4baee4, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #62423 (Fix cycle error with existential types)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #62982 (Don't access a static just for its size and alignment)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)
 - #63036 (Add lib section to rustc_lexer's Cargo.toml)

Failed merges:

r? @ghost

@bors bors merged commit 98f29f5 into rust-lang:master Jul 27, 2019

4 of 5 checks passed

homu Testing commit 98f29f5e38bc385f661fc81d67f980bc0e91d6e4 with merge 0ee6ce723198fcd11d708cb987beaf39e11d1cd5...
Details
pr Build #20190727.22 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@topecongiro topecongiro deleted the topecongiro:add-lib-section branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.