Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bare trait lint applying to macro call sites #63014

Merged
merged 2 commits into from Jul 27, 2019

Conversation

@davidtwco
Copy link
Member

commented Jul 26, 2019

Fixes #61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.

r? @estebank

davidtwco and others added some commits Jul 20, 2019

tests: Add minimal reproduction of #61963.
This commit adds a reproduction of the error reported in servo which
demonstrates the current, incorrect behaviour.

Co-authored-by: Rémy Rakić <remy.rakic@gmail.com>
lowering: Omit bare trait lint on macro call sites
This commit implements a hacky fix for detecting when a span is pointing
at a macro call site so that bare trait lints are not made incorrectly.
@estebank

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

The code seems correct, but the I'm not sure about the repro. What is the output for that test without the patch applied?

@davidtwco

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

The code seems correct, but the I'm not sure about the repro. What is the output for that test without the patch applied?

You can see it in the test output from the first commit (44bf6b6).

@estebank

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

📌 Commit cae8680 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019

Rollup merge of rust-lang#63014 - davidtwco:rustfix-incorrect-dyn-sug…
…gestion, r=estebank

Stop bare trait lint applying to macro call sites

Fixes rust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.

r? @estebank

bors added a commit that referenced this pull request Jul 26, 2019

Auto merge of #63025 - Centril:rollup-10kfdv9, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #61207 (Allow lifetime elision in `Pin<&(mut) Self>`)
 - #62771 (Break dependencies between `syntax_ext` and other crates)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost

bors added a commit that referenced this pull request Jul 26, 2019

Auto merge of #63025 - Centril:rollup-10kfdv9, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #61207 (Allow lifetime elision in `Pin<&(mut) Self>`)
 - #62771 (Break dependencies between `syntax_ext` and other crates)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019

Rollup merge of rust-lang#63014 - davidtwco:rustfix-incorrect-dyn-sug…
…gestion, r=estebank

Stop bare trait lint applying to macro call sites

Fixes rust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.

r? @estebank

bors added a commit that referenced this pull request Jul 26, 2019

Auto merge of #63028 - Centril:rollup-1jekkw7, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #62086 (Define built-in macros through libcore)
 - #62550 (Implement RFC 2707 + Parser recovery for range patterns)
 - #62949 (Re-enable assertions in PPC dist builder)
 - #62974 (bump crossbeam-epoch dependency)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

 - #62910 (cleanup: Remove lint annotations in specific crates that are already enforced by rustbuild)

r? @ghost

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 27, 2019

Rollup merge of rust-lang#63014 - davidtwco:rustfix-incorrect-dyn-sug…
…gestion, r=estebank

Stop bare trait lint applying to macro call sites

Fixes rust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.

r? @estebank

bors added a commit that referenced this pull request Jul 27, 2019

Auto merge of #63030 - Mark-Simulacrum:rollup-3yw3i09, r=Mark-Simulacrum
Rollup of 5 pull requests

Successful merges:

 - #62392 (Update minifier-rs version)
 - #62550 (Implement RFC 2707 + Parser recovery for range patterns)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019

Rollup merge of rust-lang#63014 - davidtwco:rustfix-incorrect-dyn-sug…
…gestion, r=estebank

Stop bare trait lint applying to macro call sites

Fixes rust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.

r? @estebank

bors added a commit that referenced this pull request Jul 27, 2019

Auto merge of #63043 - Centril:rollup-f4baee4, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #62423 (Fix cycle error with existential types)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #62982 (Don't access a static just for its size and alignment)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)
 - #63036 (Add lib section to rustc_lexer's Cargo.toml)

Failed merges:

r? @ghost

@bors bors merged commit cae8680 into rust-lang:master Jul 27, 2019

4 checks passed

pr Build #20190726.64 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@davidtwco davidtwco deleted the davidtwco:rustfix-incorrect-dyn-suggestion branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.