Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hygiene of `alloc::format!` #64060

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@petrochenkov
Copy link
Contributor

commented Sep 1, 2019

format now uses format_args though a __export module, as described in #63687 (comment).

Fixes #63687

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-01T11:13:48.8524332Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-01T11:13:48.8720632Z ##[command]git config gc.auto 0
2019-09-01T11:13:48.8798078Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-01T11:13:48.8853842Z ##[command]git config --get-all http.proxy
2019-09-01T11:13:48.8993615Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64060/merge:refs/remotes/pull/64060/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@dtolnay
dtolnay approved these changes Sep 2, 2019
@dtolnay

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@bors r+

But I would like to see the hygienic suggestion from #63687 (comment) implemented. That approach of $crate::__export::... is common practice in the library ecosystem.

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

📌 Commit dc447e0 has been approved by dtolnay

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@bors r-
(I'll change the PR to use __export.)

@JohnCSimon

This comment has been minimized.

Copy link

commented Sep 7, 2019

Ping from triage -
@petrochenkov - What is the status of this PR?
Thank you.

@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

Will update in a couple of days.

@petrochenkov petrochenkov force-pushed the petrochenkov:unstdhyg branch from dc447e0 to d42e603 Sep 7, 2019
@petrochenkov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

Updated.

@lzutao

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2019

Should we change the PR title too?

@petrochenkov petrochenkov changed the title Revert "hygienization" of `alloc::format!` Improve hygiene of `alloc::format!` Sep 8, 2019
@tmandry

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

📌 Commit d42e603 has been approved by tmandry

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

⌛️ Testing commit d42e603 with merge ce8b01c...

bors added a commit that referenced this pull request Sep 10, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in #63687 (comment).

Fixes #63687
tmandry added a commit to tmandry/rust that referenced this pull request Sep 10, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@tmandry

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64250 (save-analysis: Nest typeck tables when processing functions/methods)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

⌛️ Testing commit d42e603 with merge 679d12d...

bors added a commit that referenced this pull request Sep 10, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in #63687 (comment).

Fixes #63687
Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Sep 10, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

⌛️ Testing commit d42e603 with merge 7e56c23...

bors added a commit that referenced this pull request Sep 11, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in #63687 (comment).

Fixes #63687
Centril added a commit to Centril/rust that referenced this pull request Sep 11, 2019
Improve hygiene of `alloc::format!`

`format` now uses `format_args` though a `__export` module, as described in rust-lang#63687 (comment).

Fixes rust-lang#63687
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Sep 11, 2019
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64326 (Fixed documentation within c_str::from_ptr)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

⌛️ Testing commit d42e603 with merge 74d5c70...

@bors bors merged commit d42e603 into rust-lang:master Sep 11, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit d42e60331fb08efce78e7fc9739bf42620e51f8f with merge 74d5c70b174f06843049af2d764ff57ddc81c81c...
Details
pr Build #20190907.31 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.