Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak unsatisfied HRTB errors #64085

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@estebank
Copy link
Contributor

commented Sep 2, 2019

r? @oli-obk

Close #35180.

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

ping

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

📌 Commit 32440cb has been approved by oli-obk

tmandry added a commit to tmandry/rust that referenced this pull request Sep 10, 2019
bors added a commit that referenced this pull request Sep 10, 2019
Auto merge of #64366 - tmandry:rollup-vy8wdo1, r=tmandry
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64250 (save-analysis: Nest typeck tables when processing functions/methods)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
bors added a commit that referenced this pull request Sep 10, 2019
Auto merge of #64368 - Centril:rollup-4s8ko6f, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #64060 (Improve hygiene of `alloc::format!`)
 - #64072 (Replace file_stem by file_name in rustdoc markdown)
 - #64085 (Tweak unsatisfied HRTB errors)
 - #64129 (vxWorks: set DEFAULT_MIN_STACK_SIZE to 256K and use min_stack to pass initial stack size to rtpSpawn)
 - #64188 (rustc: Allow the cdylib crate type with wasm32-wasi)
 - #64349 (documentation for AtomicPtr CAS operations)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Failed in #64368 (comment), @bors r-

Please do --bless --compare-mode=nll when adjusting HRTB diagnostics.

@estebank estebank force-pushed the estebank:hrtb-errors branch from 32440cb to 0a985f2 Sep 16, 2019

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

📌 Commit 0a985f2 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

⌛️ Testing commit 0a985f2 with merge 04598e7...

bors added a commit that referenced this pull request Sep 17, 2019
Auto merge of #64085 - estebank:hrtb-errors, r=oli-obk
Tweak unsatisfied HRTB errors

r? @oli-obk

Close #35180.
Centril added a commit to Centril/rust that referenced this pull request Sep 17, 2019
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Sep 17, 2019
Auto merge of #64535 - Centril:rollup-wiyxagi, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #64085 (Tweak unsatisfied HRTB errors)
 - #64380 (Update bundled OpenSSL to 1.1.1d)
 - #64416 (Various refactorings to clean up nll diagnostics)
 - #64500 (Various `ObligationForest` improvements)
 - #64530 (Elide lifetimes in `Pin<&(mut) Self>`)
 - #64531 (Use shorthand syntax in the self parameter of methods of Pin)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

⌛️ Testing commit 0a985f2 with merge 5670d04...

@bors bors merged commit 0a985f2 into rust-lang:master Sep 17, 2019

4 of 5 checks passed

homu Testing commit 0a985f2c86add139d880882c968e68747b366be6 with merge 5670d048c0f88af9976b5505c7853b23dd06770d...
Details
pr Build #20190916.65 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.