Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize `#[non_exhaustive]` (RFC 2008) #64639

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@davidtwco
Copy link
Member

davidtwco commented Sep 20, 2019

Fixes #44109.

This pull request stabilizes the #[non_exhaustive] attribute, which is used to indicate that a type will have more fields / variants added in the future. It can be applied to structs, enums and enum variants. See #44109 (comment) for the stabilization report.

r? @Centril

@rust-highfive

This comment was marked as spam.

Copy link
Collaborator

rust-highfive commented Sep 20, 2019

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

Copy link
Member

Centril left a comment

Thanks! Once FCP completes, r=me with these nits addressed.

src/libsyntax/feature_gate/accepted.rs Outdated Show resolved Hide resolved
src/libsyntax/feature_gate/builtin_attrs.rs Outdated Show resolved Hide resolved
@Centril Centril added T-lang and removed S-waiting-on-review labels Sep 21, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Sep 21, 2019

☔️ The latest upstream changes (presumably #64658) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco davidtwco force-pushed the davidtwco:rfc-2008-stabilization branch from 847b77b to 125f483 Sep 21, 2019
@Aaron1011

This comment was marked as resolved.

Copy link
Contributor

Aaron1011 commented Sep 21, 2019

@davidtwco: Could you add something about #[non_exhaustive] to the title? It would make it easier to remember what this PR is about when viewing it in the PR list.

@Centril Centril changed the title RFC 2008: Stabilization Stabilize `#[non_exhaustive]` (RFC 2008) Sep 21, 2019
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Oct 1, 2019

☔️ The latest upstream changes (presumably #64946) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco davidtwco force-pushed the davidtwco:rfc-2008-stabilization branch from 125f483 to 62e0fb2 Oct 1, 2019
@davidtwco davidtwco force-pushed the davidtwco:rfc-2008-stabilization branch from 62e0fb2 to d5b1d47 Oct 6, 2019
@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Oct 6, 2019

Updated this PR after #65130 landed.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 6, 2019

Seems like a bug was found meanwhile in #65157 which is fallout from #60529. Ideally this should be fixed before we stabilize the feature. cc @Nadrieril.

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Oct 11, 2019

☔️ The latest upstream changes (presumably #64716) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco davidtwco force-pushed the davidtwco:rfc-2008-stabilization branch from d5b1d47 to 23fd40f Oct 14, 2019
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 25, 2019

#65414 just landed.

This commit stabilizes RFC 2008 (#44109) by removing the feature gate.

Signed-off-by: David Wood <david@davidtw.co>
@davidtwco davidtwco force-pushed the davidtwco:rfc-2008-stabilization branch from 23fd40f to e0590ea Oct 25, 2019
@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Oct 25, 2019

Rebased atop #65414 having landed.

Copy link
Member

Centril left a comment

Thanks! r=me when green

@davidtwco

This comment has been minimized.

Copy link
Member Author

davidtwco commented Oct 25, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit e0590ea has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…=Centril

Stabilize `#[non_exhaustive]` (RFC 2008)

Fixes rust-lang#44109.

This pull request stabilizes the `#[non_exhaustive]` attribute, which is used to indicate that a type will have more fields / variants added in the future. It can be applied to `struct`s, `enum`s and `enum` variants. See rust-lang#44109 (comment) for the stabilization report.

r? @Centril
bors added a commit that referenced this pull request Oct 25, 2019
Rollup of 9 pull requests

Successful merges:

 - #64639 (Stabilize `#[non_exhaustive]` (RFC 2008))
 - #65074 (Fix the start/end byte positions in the compiler JSON output)
 - #65315 (Intern place projection)
 - #65685 (Fix check of `statx` and handle EPERM)
 - #65731 (Prevent unnecessary allocation in PathBuf::set_extension.)
 - #65740 (Fix default "disable-shortcuts" feature value)
 - #65787 (move panictry! to where it is used.)
 - #65789 (move Attribute::with_desugared_doc to librustdoc)
 - #65790 (move report_invalid_macro_expansion_item to item.rs)

Failed merges:

r? @ghost
@bors bors merged commit e0590ea into rust-lang:master Oct 25, 2019
4 checks passed
4 checks passed
pr Build #20191025.36 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@davidtwco davidtwco deleted the davidtwco:rfc-2008-stabilization branch Oct 25, 2019
@jhpratt

This comment has been minimized.

Copy link

jhpratt commented Oct 30, 2019

I see the milestone is listed as 1.40. Don't things like this typically go through beta first?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Oct 30, 2019

The current nightly is 1.40, and in about a week we will ship 1.39 to stable, making 1.40 the beta, and as such in ~7 weeks this will land in stable.

@jhpratt

This comment has been minimized.

Copy link

jhpratt commented Oct 30, 2019

Oh yeah, for some reason I thought we were already on 1.39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.