Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint ignored `#[inline]` on function prototypes #65294

Merged
merged 12 commits into from Oct 29, 2019

Conversation

@varkor
Copy link
Member

varkor commented Oct 11, 2019

Fixes #51280.

  • Adds a unused_attribute lint for #[inline] on function prototypes.
  • As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 11, 2019

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-11T01:43:19.0836625Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-11T01:43:19.0923997Z ##[command]git config gc.auto 0
2019-10-11T01:43:19.1011319Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-11T01:43:19.1078670Z ##[command]git config --get-all http.proxy
2019-10-11T01:43:19.1214486Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65294/merge:refs/remotes/pull/65294/merge
---
2019-10-11T02:15:09.5374260Z    Compiling jobserver v0.1.16
2019-10-11T02:15:11.9251952Z    Compiling env_logger v0.7.0
2019-10-11T02:15:12.5820649Z    Compiling rustc-hash v1.0.1
2019-10-11T02:15:12.6895384Z    Compiling rustc_apfloat v0.0.0 (/checkout/src/librustc_apfloat)
2019-10-11T02:15:12.8708523Z error[E0518]: attribute should be applied to function or closure
2019-10-11T02:15:12.8708962Z    --> <::bitflags::__impl_bitflags macros>:73:22
2019-10-11T02:15:12.8709318Z     |
2019-10-11T02:15:12.8711001Z 1   |   /   ($ BitFlags : ident : $ T : ty
2019-10-11T02:15:12.8711767Z 3   |   |        $
2019-10-11T02:15:12.8711767Z 3   |   |        $
2019-10-11T02:15:12.8712190Z 4   |   |        ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-11T02:15:12.8712510Z ...     |
2019-10-11T02:15:12.8712925Z 73  |   |                   { $ (# [inline] const $ Flag : $ T = 0 ;) + } impl __BitFlags
2019-10-11T02:15:12.8713675Z     |   |                        ^^^^^^^^^^ ------------------------ not a function or closure
2019-10-11T02:15:12.8714041Z ...     |
2019-10-11T02:15:12.8714456Z 248 |   |   } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-11T02:15:12.8714856Z 249 |   |   { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-11T02:15:12.8715668Z     |   |_______________________________________________- in this expansion of `__impl_bitflags!` (#3)
2019-10-11T02:15:12.8715986Z     | 
2019-10-11T02:15:12.8716573Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-11T02:15:12.8716882Z     |
2019-10-11T02:15:12.8717323Z 1   |     / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-11T02:15:12.8717724Z 2   |     |  {
2019-10-11T02:15:12.8718091Z 3   |     |      $
2019-10-11T02:15:12.8718539Z 4   |     |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-11T02:15:12.8718871Z ...       |
2019-10-11T02:15:12.8719303Z 10  |     |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-11T02:15:12.8719684Z     |  ___|_______________________________________-
2019-10-11T02:15:12.8720091Z 11  | |   |     {
2019-10-11T02:15:12.8720497Z 12  | |   |         $ BitFlags : $ T
2019-10-11T02:15:12.8720983Z 13  | |   |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-11T02:15:12.8721776Z     | |___|_____- in this macro invocation (#3)
2019-10-11T02:15:12.8722165Z 15  |     | } ;
2019-10-11T02:15:12.8722165Z 15  |     | } ;
2019-10-11T02:15:12.8722571Z     |     |___- in this expansion of `__bitflags!` (#2)
2019-10-11T02:15:12.8722862Z     | 
2019-10-11T02:15:12.8723176Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-11T02:15:12.8723433Z     |
2019-10-11T02:15:12.8723878Z 1   |    /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-11T02:15:12.8724238Z 2   |    |   {
2019-10-11T02:15:12.8724617Z 3   |    |       $
2019-10-11T02:15:12.8725582Z 4   |    |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-11T02:15:12.8725935Z ...      |
2019-10-11T02:15:12.8726309Z 8   |  / |      __bitflags !
2019-10-11T02:15:12.8726720Z 9   |  | |      {
2019-10-11T02:15:12.8727185Z 10  |  | |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-11T02:15:12.8727820Z 11  |  | |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-11T02:15:12.8773575Z     |  |_|______- in this macro invocation (#2)
2019-10-11T02:15:12.8773931Z ...      |
2019-10-11T02:15:12.8774269Z 39  |    |      }
2019-10-11T02:15:12.8774600Z 40  |    |  } ;
2019-10-11T02:15:12.8774600Z 40  |    |  } ;
2019-10-11T02:15:12.8775333Z     |    |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-11T02:15:12.8775992Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-11T02:15:12.8776244Z     |
2019-10-11T02:15:12.8776583Z 48  | /     bitflags::bitflags! {
2019-10-11T02:15:12.8776583Z 48  | /     bitflags::bitflags! {
2019-10-11T02:15:12.8776975Z 49  | |         /// IEEE-754R 7: Default exception handling.
2019-10-11T02:15:12.8777312Z 50  | |         ///
2019-10-11T02:15:12.8777702Z 51  | |         /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-11T02:15:12.8778344Z 60  | |         }
2019-10-11T02:15:12.8778662Z 61  | |     }
2019-10-11T02:15:12.8779031Z     | |_____- in this macro invocation (#1)
2019-10-11T02:15:12.8779124Z 
---
2019-10-11T02:15:14.2458568Z == clock drift check ==
2019-10-11T02:15:14.2477280Z   local time: Fri Oct 11 02:15:14 UTC 2019
2019-10-11T02:15:14.3990238Z   network time: Fri, 11 Oct 2019 02:15:14 GMT
2019-10-11T02:15:14.3995582Z == end clock drift check ==
2019-10-11T02:15:15.3551616Z ##[error]Bash exited with code '1'.
2019-10-11T02:15:15.3604602Z ##[section]Starting: Checkout
2019-10-11T02:15:15.3607259Z ==============================================================================
2019-10-11T02:15:15.3607327Z Task         : Get sources
2019-10-11T02:15:15.3607382Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 11, 2019

cc @rust-lang/lang This seems like a reasonable extension of the unused_attributes lint so I'm not going to I-nominate the PR for a language team meeting to save us time but I thought y'all should be aware. :)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 11, 2019

We should do a crater run of this once it builds, because it's possible (as seen in bitflags) that there are accidental #[inline] attributes on trait or extern items that don't permit them. Hopefully we can just fix the fallout; it'd be ugly to have to continue to allow these for some time.

@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Oct 11, 2019

Hopefully we can just fix the fallout; it'd be ugly to have to continue to allow these for some time.

This is just a lint, right? I don't think we need a crater run to ward off ecosystem breakage for new lints, especially on one that's so niche.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 11, 2019

If you look at the diff it introduces both warnings and errors in different places.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Oct 11, 2019

Based on my skimming of the tests, is it correct that the errors arise when #[inline] is applied to non-functions, like consts or statics? And this used to just be ignored or something?

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 11, 2019

Errors were previously emitted on #[inline] on consts or statics (any non-functions), but they were not being emitted on associated/foreign items (which was an oversight). Now they're emitted on any item, which was a natural consequence of adding the lint for #[inline] on prototypes.

So this adds both a lint, but also errors that had previously accidentally been left out.

src/librustc/hir/check_attr.rs Show resolved Hide resolved
src/librustc/hir/check_attr.rs Outdated Show resolved Hide resolved
@varkor varkor mentioned this pull request Oct 13, 2019
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-13T15:15:41.9386755Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-13T15:15:41.9493789Z ##[command]git config gc.auto 0
2019-10-13T15:15:41.9545915Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-13T15:15:41.9595552Z ##[command]git config --get-all http.proxy
2019-10-13T15:15:41.9723223Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65294/merge:refs/remotes/pull/65294/merge
---
2019-10-13T15:43:51.5426580Z    Compiling env_logger v0.7.0
2019-10-13T15:43:52.0902853Z    Compiling rustc-hash v1.0.1
2019-10-13T15:43:52.1865613Z    Compiling quote v1.0.2
2019-10-13T15:43:54.1548533Z    Compiling rustc_apfloat v0.0.0 (/checkout/src/librustc_apfloat)
2019-10-13T15:43:54.3129171Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.3129513Z    --> <::bitflags::__impl_bitflags macros>:73:22
2019-10-13T15:43:54.3129692Z     |
2019-10-13T15:43:54.3129952Z 1   |   /   ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3130424Z 3   |   |        $
2019-10-13T15:43:54.3130424Z 3   |   |        $
2019-10-13T15:43:54.3130881Z 4   |   |        ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.3131541Z ...     |
2019-10-13T15:43:54.3131961Z 73  |   |                   { $ (# [inline] const $ Flag : $ T = 0 ;) + } impl __BitFlags
2019-10-13T15:43:54.3132402Z     |   |                        ^^^^^^^^^^ ------------------------ not a function or closure
2019-10-13T15:43:54.3132690Z ...     |
2019-10-13T15:43:54.3133037Z 248 |   |   } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.3133401Z 249 |   |   { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.3133778Z     |   |_______________________________________________- in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.3134044Z     | 
2019-10-13T15:43:54.3134316Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.3134849Z     |
2019-10-13T15:43:54.3135132Z 1   |     / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3135352Z 2   |     |  {
2019-10-13T15:43:54.3135588Z 3   |     |      $
2019-10-13T15:43:54.3135854Z 4   |     |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.3136286Z ...       |
2019-10-13T15:43:54.3136668Z 10  |     |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.3136917Z     |  ___|_______________________________________-
2019-10-13T15:43:54.3137149Z 11  | |   |     {
2019-10-13T15:43:54.3137414Z 12  | |   |         $ BitFlags : $ T
2019-10-13T15:43:54.3137691Z 13  | |   |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.3138198Z     | |___|_____- in this macro invocation (#3)
2019-10-13T15:43:54.3138413Z 15  |     | } ;
2019-10-13T15:43:54.3138413Z 15  |     | } ;
2019-10-13T15:43:54.3138673Z     |     |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.3138835Z     | 
2019-10-13T15:43:54.3139021Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.3139197Z     |
2019-10-13T15:43:54.3139450Z 1   |    /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3139698Z 2   |    |   {
2019-10-13T15:43:54.3139918Z 3   |    |       $
2019-10-13T15:43:54.3140178Z 4   |    |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.3140383Z ...      |
2019-10-13T15:43:54.3140805Z 8   |  / |      __bitflags !
2019-10-13T15:43:54.3142080Z 9   |  | |      {
2019-10-13T15:43:54.3142662Z 10  |  | |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.3143058Z 11  |  | |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.3143730Z     |  |_|______- in this macro invocation (#2)
2019-10-13T15:43:54.3143975Z ...      |
2019-10-13T15:43:54.3144290Z 39  |    |      }
2019-10-13T15:43:54.3144964Z 40  |    |  } ;
2019-10-13T15:43:54.3144964Z 40  |    |  } ;
2019-10-13T15:43:54.3145235Z     |    |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.3145605Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.3145759Z     |
2019-10-13T15:43:54.3145995Z 48  | /     bitflags::bitflags! {
2019-10-13T15:43:54.3145995Z 48  | /     bitflags::bitflags! {
2019-10-13T15:43:54.3146235Z 49  | |         /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.3146655Z 50  | |         ///
2019-10-13T15:43:54.3147146Z 51  | |         /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.3148004Z 60  | |         }
2019-10-13T15:43:54.3148453Z 61  | |     }
2019-10-13T15:43:54.3148744Z     | |_____- in this macro invocation (#1)
2019-10-13T15:43:54.3148803Z 
2019-10-13T15:43:54.3148803Z 
2019-10-13T15:43:54.3734187Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.3734604Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.3734859Z     |
2019-10-13T15:43:54.3735321Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3797210Z 3   |   |         $
2019-10-13T15:43:54.3797210Z 3   |   |         $
2019-10-13T15:43:54.3797507Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.3797729Z ...     |
2019-10-13T15:43:54.3797984Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.3798238Z     |  _|_________________________-
2019-10-13T15:43:54.3798504Z 78  | | |                         {
2019-10-13T15:43:54.3798805Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.3799108Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.3799383Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.3799844Z     |  _|___________________________________________________-
2019-10-13T15:43:54.3800187Z 82  | | |                         }) +
2019-10-13T15:43:54.3801457Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.3801457Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.3801915Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.3803796Z ...   | |
2019-10-13T15:43:54.3804225Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.3804901Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.3805564Z     | | |                               |                |
2019-10-13T15:43:54.3805564Z     | | |                               |                |
2019-10-13T15:43:54.3805883Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.3806407Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.3807018Z     | 
2019-10-13T15:43:54.3807018Z     | 
2019-10-13T15:43:54.3807216Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.3807385Z     |
2019-10-13T15:43:54.3807663Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3807905Z 2   |      |  {
2019-10-13T15:43:54.3808157Z 3   |      |      $
2019-10-13T15:43:54.3808442Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.3808653Z ...        |
2019-10-13T15:43:54.3808916Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.3809402Z 11  | |    |     {
2019-10-13T15:43:54.3809402Z 11  | |    |     {
2019-10-13T15:43:54.3809893Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.3810224Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.3810894Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.3811543Z 15  |      | } ;
2019-10-13T15:43:54.3811543Z 15  |      | } ;
2019-10-13T15:43:54.3811877Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.3812116Z     | 
2019-10-13T15:43:54.3812381Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.3812595Z     |
2019-10-13T15:43:54.3812951Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.3813254Z 2   |     |   {
2019-10-13T15:43:54.3813551Z 3   |     |       $
2019-10-13T15:43:54.3813917Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.3814183Z ...       |
2019-10-13T15:43:54.3814521Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.3814971Z 9   |  |  |      {
2019-10-13T15:43:54.3815253Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.3815569Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.3816085Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.3816288Z ...       |
2019-10-13T15:43:54.3816512Z 39  |     |      }
2019-10-13T15:43:54.3816739Z 40  |     |  } ;
2019-10-13T15:43:54.3816739Z 40  |     |  } ;
2019-10-13T15:43:54.3817001Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.3817375Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.3817661Z     |
2019-10-13T15:43:54.3817892Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.3817892Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.3818218Z 49  | |          /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.3818475Z 50  | |          ///
2019-10-13T15:43:54.3818746Z 51  | |          /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.3819205Z 60  | |          }
2019-10-13T15:43:54.3819423Z 61  | |      }
2019-10-13T15:43:54.3819674Z     | |______- in this macro invocation (#1)
2019-10-13T15:43:54.3819712Z 
2019-10-13T15:43:54.3819712Z 
2019-10-13T15:43:54.4246866Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.4247571Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.4248030Z     |
2019-10-13T15:43:54.4248560Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4249675Z 3   |   |         $
2019-10-13T15:43:54.4249675Z 3   |   |         $
2019-10-13T15:43:54.4250216Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.4250847Z ...     |
2019-10-13T15:43:54.4251920Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.4252520Z     |  _|_________________________-
2019-10-13T15:43:54.4253177Z 78  | | |                         {
2019-10-13T15:43:54.4253857Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.4254765Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.4255273Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.4255752Z     |  _|___________________________________________________-
2019-10-13T15:43:54.4256245Z 82  | | |                         }) +
2019-10-13T15:43:54.4257236Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.4257236Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.4258098Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.4258612Z ...   | |
2019-10-13T15:43:54.4259124Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.4259657Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.4261323Z     | | |                               |                |
2019-10-13T15:43:54.4261323Z     | | |                               |                |
2019-10-13T15:43:54.4262125Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.4262905Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.4264166Z     | 
2019-10-13T15:43:54.4264166Z     | 
2019-10-13T15:43:54.4265123Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.4265534Z     |
2019-10-13T15:43:54.4266046Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4266526Z 2   |      |  {
2019-10-13T15:43:54.4266987Z 3   |      |      $
2019-10-13T15:43:54.4267502Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.4267945Z ...        |
2019-10-13T15:43:54.4268440Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.4269398Z 11  | |    |     {
2019-10-13T15:43:54.4269398Z 11  | |    |     {
2019-10-13T15:43:54.4269899Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.4270420Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.4274210Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.4274977Z 15  |      | } ;
2019-10-13T15:43:54.4274977Z 15  |      | } ;
2019-10-13T15:43:54.4275459Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.4275639Z     | 
2019-10-13T15:43:54.4275852Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.4276023Z     |
2019-10-13T15:43:54.4276301Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4276549Z 2   |     |   {
2019-10-13T15:43:54.4276795Z 3   |     |       $
2019-10-13T15:43:54.4277095Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.4277304Z ...       |
2019-10-13T15:43:54.4277569Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.4277837Z 9   |  |  |      {
2019-10-13T15:43:54.4278135Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.4278620Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.4279322Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.4279512Z ...       |
2019-10-13T15:43:54.4279731Z 39  |     |      }
2019-10-13T15:43:54.4279948Z 40  |     |  } ;
2019-10-13T15:43:54.4279948Z 40  |     |  } ;
2019-10-13T15:43:54.4280204Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.4280560Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.4280913Z     |
2019-10-13T15:43:54.4281927Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.4281927Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.4282277Z 49  | |          /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.4282590Z 50  | |          ///
2019-10-13T15:43:54.4282945Z 51  | |          /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.4283780Z 60  | |          }
2019-10-13T15:43:54.4284104Z 61  | |      }
2019-10-13T15:43:54.4284423Z     | |______- in this macro invocation (#1)
2019-10-13T15:43:54.4284465Z 
2019-10-13T15:43:54.4284465Z 
2019-10-13T15:43:54.4925739Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.4926001Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.4926165Z     |
2019-10-13T15:43:54.4926397Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4926867Z 3   |   |         $
2019-10-13T15:43:54.4926867Z 3   |   |         $
2019-10-13T15:43:54.4927145Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.4927329Z ...     |
2019-10-13T15:43:54.4927569Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.4927791Z     |  _|_________________________-
2019-10-13T15:43:54.4928049Z 78  | | |                         {
2019-10-13T15:43:54.4928334Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.4928639Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.4928894Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.4929128Z     |  _|___________________________________________________-
2019-10-13T15:43:54.4929376Z 82  | | |                         }) +
2019-10-13T15:43:54.4931519Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.4931519Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.4931929Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.4932241Z ...   | |
2019-10-13T15:43:54.4932620Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.4933368Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.4934556Z     | | |                               |                |
2019-10-13T15:43:54.4934556Z     | | |                               |                |
2019-10-13T15:43:54.4934874Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.4935189Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.4935667Z     | 
2019-10-13T15:43:54.4935667Z     | 
2019-10-13T15:43:54.4935882Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.4936072Z     |
2019-10-13T15:43:54.4936370Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4936622Z 2   |      |  {
2019-10-13T15:43:54.4936883Z 3   |      |      $
2019-10-13T15:43:54.4937203Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.4937415Z ...        |
2019-10-13T15:43:54.4937713Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.4938235Z 11  | |    |     {
2019-10-13T15:43:54.4938235Z 11  | |    |     {
2019-10-13T15:43:54.4938523Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.4938854Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.4939402Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.4939651Z 15  |      | } ;
2019-10-13T15:43:54.4939651Z 15  |      | } ;
2019-10-13T15:43:54.4939940Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.4940125Z     | 
2019-10-13T15:43:54.4940350Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.4941144Z     |
2019-10-13T15:43:54.4941626Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.4941989Z 2   |     |   {
2019-10-13T15:43:54.4942293Z 3   |     |       $
2019-10-13T15:43:54.4942661Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.4942930Z ...       |
2019-10-13T15:43:54.4943264Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.4943617Z 9   |  |  |      {
2019-10-13T15:43:54.4944007Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.4944508Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.4945026Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.4945225Z ...       |
2019-10-13T15:43:54.4945470Z 39  |     |      }
2019-10-13T15:43:54.4945703Z 40  |     |  } ;
2019-10-13T15:43:54.4945703Z 40  |     |  } ;
2019-10-13T15:43:54.4945971Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.4946336Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.4946512Z     |
2019-10-13T15:43:54.4946743Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.4946743Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.4947011Z 49  | |          /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.4947254Z 50  | |          ///
2019-10-13T15:43:54.4947534Z 51  | |          /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.4947955Z 60  | |          }
2019-10-13T15:43:54.4948175Z 61  | |      }
2019-10-13T15:43:54.4948412Z     | |______- in this macro invocation (#1)
2019-10-13T15:43:54.4948538Z 
2019-10-13T15:43:54.4948538Z 
2019-10-13T15:43:54.5407606Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.5408064Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.5408300Z     |
2019-10-13T15:43:54.5408548Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.5409028Z 3   |   |         $
2019-10-13T15:43:54.5409028Z 3   |   |         $
2019-10-13T15:43:54.5409312Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.5409533Z ...     |
2019-10-13T15:43:54.5409795Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.5410016Z     |  _|_________________________-
2019-10-13T15:43:54.5410290Z 78  | | |                         {
2019-10-13T15:43:54.5411092Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.5411544Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.5411915Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.5412231Z     |  _|___________________________________________________-
2019-10-13T15:43:54.5412597Z 82  | | |                         }) +
2019-10-13T15:43:54.5413288Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.5413288Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.5413683Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.5413985Z ...   | |
2019-10-13T15:43:54.5414513Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.5414797Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.5415440Z     | | |                               |                |
2019-10-13T15:43:54.5415440Z     | | |                               |                |
2019-10-13T15:43:54.5415987Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.5416348Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.5416817Z     | 
2019-10-13T15:43:54.5416817Z     | 
2019-10-13T15:43:54.5417034Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.5417217Z     |
2019-10-13T15:43:54.5417534Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.5417807Z 2   |      |  {
2019-10-13T15:43:54.5418064Z 3   |      |      $
2019-10-13T15:43:54.5418383Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.5418596Z ...        |
2019-10-13T15:43:54.5418944Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.5419480Z 11  | |    |     {
2019-10-13T15:43:54.5419480Z 11  | |    |     {
2019-10-13T15:43:54.5419778Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.5420095Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.5421257Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.5421588Z 15  |      | } ;
2019-10-13T15:43:54.5421588Z 15  |      | } ;
2019-10-13T15:43:54.5421941Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.5422168Z     | 
2019-10-13T15:43:54.5422423Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.5422651Z     |
2019-10-13T15:43:54.5423004Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.5423306Z 2   |     |   {
2019-10-13T15:43:54.5423622Z 3   |     |       $
2019-10-13T15:43:54.5424203Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.5424691Z ...       |
2019-10-13T15:43:54.5424990Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.5425251Z 9   |  |  |      {
2019-10-13T15:43:54.5425562Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.5425865Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.5426411Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.5426604Z ...       |
2019-10-13T15:43:54.5426843Z 39  |     |      }
2019-10-13T15:43:54.5427075Z 40  |     |  } ;
2019-10-13T15:43:54.5427075Z 40  |     |  } ;
2019-10-13T15:43:54.5427334Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.5427728Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.5427900Z     |
2019-10-13T15:43:54.5428148Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.5428148Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.5428409Z 49  | |          /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.5428637Z 50  | |          ///
2019-10-13T15:43:54.5428924Z 51  | |          /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.5429358Z 60  | |          }
2019-10-13T15:43:54.5429587Z 61  | |      }
2019-10-13T15:43:54.5429828Z     | |______- in this macro invocation (#1)
2019-10-13T15:43:54.5429870Z 
2019-10-13T15:43:54.5429870Z 
2019-10-13T15:43:54.6007173Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.6007428Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.6007615Z     |
2019-10-13T15:43:54.6007846Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6008534Z 3   |   |         $
2019-10-13T15:43:54.6008534Z 3   |   |         $
2019-10-13T15:43:54.6008891Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.6009129Z ...     |
2019-10-13T15:43:54.6009374Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.6009581Z     |  _|_________________________-
2019-10-13T15:43:54.6009841Z 78  | | |                         {
2019-10-13T15:43:54.6010118Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.6010435Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.6011343Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.6011667Z     |  _|___________________________________________________-
2019-10-13T15:43:54.6012030Z 82  | | |                         }) +
2019-10-13T15:43:54.6012750Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.6012750Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.6013147Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.6013429Z ...   | |
2019-10-13T15:43:54.6013818Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.6014499Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.6015122Z     | | |                               |                |
2019-10-13T15:43:54.6015122Z     | | |                               |                |
2019-10-13T15:43:54.6015410Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.6015725Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.6016315Z     | 
2019-10-13T15:43:54.6016315Z     | 
2019-10-13T15:43:54.6016595Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.6016800Z     |
2019-10-13T15:43:54.6017098Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6017342Z 2   |      |  {
2019-10-13T15:43:54.6017580Z 3   |      |      $
2019-10-13T15:43:54.6017879Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.6018094Z ...        |
2019-10-13T15:43:54.6018372Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.6018870Z 11  | |    |     {
2019-10-13T15:43:54.6018870Z 11  | |    |     {
2019-10-13T15:43:54.6019147Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.6019453Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.6019990Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.6020233Z 15  |      | } ;
2019-10-13T15:43:54.6020233Z 15  |      | } ;
2019-10-13T15:43:54.6020981Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.6021267Z     | 
2019-10-13T15:43:54.6021528Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.6021761Z     |
2019-10-13T15:43:54.6022115Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6022435Z 2   |     |   {
2019-10-13T15:43:54.6022750Z 3   |     |       $
2019-10-13T15:43:54.6023119Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.6023372Z ...       |
2019-10-13T15:43:54.6023724Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.6024226Z 9   |  |  |      {
2019-10-13T15:43:54.6024718Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.6025039Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.6025539Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.6025719Z ...       |
2019-10-13T15:43:54.6025935Z 39  |     |      }
2019-10-13T15:43:54.6026175Z 40  |     |  } ;
2019-10-13T15:43:54.6026175Z 40  |     |  } ;
2019-10-13T15:43:54.6026427Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.6026786Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.6026942Z     |
2019-10-13T15:43:54.6027171Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.6027171Z 48  | /      bitflags::bitflags! {
2019-10-13T15:43:54.6027417Z 49  | |          /// IEEE-754R 7: Default exception handling.
2019-10-13T15:43:54.6027632Z 50  | |          ///
2019-10-13T15:43:54.6027916Z 51  | |          /// UNDERFLOW or OVERFLOW are always returned or-ed with INEXACT.
2019-10-13T15:43:54.6028310Z 60  | |          }
2019-10-13T15:43:54.6028532Z 61  | |      }
2019-10-13T15:43:54.6028756Z     | |______- in this macro invocation (#1)
2019-10-13T15:43:54.6028787Z 
2019-10-13T15:43:54.6028787Z 
2019-10-13T15:43:54.6447205Z error[E0518]: attribute should be applied to function or closure
2019-10-13T15:43:54.6447463Z    --> <::bitflags::__impl_bitflags macros>:249:6
2019-10-13T15:43:54.6447665Z     |
2019-10-13T15:43:54.6447911Z 1   |   /    ($ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6448375Z 3   |   |         $
2019-10-13T15:43:54.6448375Z 3   |   |         $
2019-10-13T15:43:54.6448644Z 4   |   |         ($ (# [$ attr : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.6448830Z ...     |
2019-10-13T15:43:54.6449091Z 77  |   |                        (__impl_bitflags !
2019-10-13T15:43:54.6449503Z     |  _|_________________________-
2019-10-13T15:43:54.6449852Z 78  | | |                         {
2019-10-13T15:43:54.6450169Z 79  | | |                             # [allow (deprecated)] # [inline] $
2019-10-13T15:43:54.6450461Z 80  | | |                             (? # [$ attr $ ($ args) *]) * const $ Flag : $ T =
2019-10-13T15:43:54.6451318Z 81  |   |                             Self :: $ Flag . bits ;
2019-10-13T15:43:54.6451648Z     |  _|___________________________________________________-
2019-10-13T15:43:54.6452021Z 82  | | |                         }) +
2019-10-13T15:43:54.6452712Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.6452712Z 83  | | |                    } $ BitFlags
2019-10-13T15:43:54.6453115Z 84  | | |                    { bits : $ (< $ BitFlags as __BitFlags > :: $ Flag) | + }
2019-10-13T15:43:54.6453393Z ...   | |
2019-10-13T15:43:54.6453801Z 248 | | |    } ; ($ (# [$ filtered : meta]) * const $ ($ item : tt) *) =>
2019-10-13T15:43:54.6454328Z 249 | | |    { $ (# [$ filtered]) * const $ ($ item) * } ;
2019-10-13T15:43:54.6455116Z     | | |                               |                |
2019-10-13T15:43:54.6455116Z     | | |                               |                |
2019-10-13T15:43:54.6455405Z     | | |_______________________________|________________in this expansion of `__impl_bitflags!` (#3)
2019-10-13T15:43:54.6455733Z     | |_________________________________|                in this expansion of `__impl_bitflags!` (#4)
2019-10-13T15:43:54.6456166Z     | 
2019-10-13T15:43:54.6456166Z     | 
2019-10-13T15:43:54.6456385Z    ::: <::bitflags::__bitflags macros>:1:1
2019-10-13T15:43:54.6456560Z     |
2019-10-13T15:43:54.6456843Z 1   |      / ($ (# [$ outer : meta]) * ($ ($ vis : tt) *) $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6457097Z 2   |      |  {
2019-10-13T15:43:54.6457563Z 3   |      |      $
2019-10-13T15:43:54.6457893Z 4   |      |      ($ (# [$ inner : ident $ ($ args : tt) *]) * $ Flag : ident = $ value :
2019-10-13T15:43:54.6458097Z ...        |
2019-10-13T15:43:54.6458371Z 10  |      |     struct $ BitFlags { bits : $ T, } __impl_bitflags !
2019-10-13T15:43:54.6458870Z 11  | |    |     {
2019-10-13T15:43:54.6458870Z 11  | |    |     {
2019-10-13T15:43:54.6459152Z 12  | |    |         $ BitFlags : $ T
2019-10-13T15:43:54.6459471Z 13  | |    |         { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.6459981Z     | |____|_____- in this macro invocation (#3)
2019-10-13T15:43:54.6460223Z 15  |      | } ;
2019-10-13T15:43:54.6460223Z 15  |      | } ;
2019-10-13T15:43:54.6460931Z     |      |___- in this expansion of `__bitflags!` (#2)
2019-10-13T15:43:54.6461260Z     | 
2019-10-13T15:43:54.6461527Z    ::: <::bitflags::bitflags macros>:1:1
2019-10-13T15:43:54.6461749Z     |
2019-10-13T15:43:54.6462124Z 1   |     /  ($ (# [$ outer : meta]) * pub struct $ BitFlags : ident : $ T : ty
2019-10-13T15:43:54.6462425Z 2   |     |   {
2019-10-13T15:43:54.6462724Z 3   |     |       $
2019-10-13T15:43:54.6463105Z 4   |     |       ($ (# [$ inner : ident $ ($ args : tt) *]) * const $ Flag : ident = $
2019-10-13T15:43:54.6463367Z ...       |
2019-10-13T15:43:54.6463724Z 8   |  /  |      __bitflags !
2019-10-13T15:43:54.6464062Z 9   |  |  |      {
2019-10-13T15:43:54.6464529Z 10  |  |  |          $ (# [$ outer]) * (pub) $ BitFlags : $ T
2019-10-13T15:43:54.6464831Z 11  |  |  |          { $ ($ (# [$ inner $ ($ args) *]) * $ Flag = $ value ;) + }
2019-10-13T15:43:54.6465565Z     |  |__|______- in this macro invocation (#2)
2019-10-13T15:43:54.6465785Z ...       |
2019-10-13T15:43:54.6466003Z 39  |     |      }
2019-10-13T15:43:54.6466238Z 40  |     |  } ;
2019-10-13T15:43:54.6466238Z 40  |     |  } ;
2019-10-13T15:43:54.6466485Z     |     |____- in this expansion of `bitflags::bitflags!` (#1)
2019-10-13T15:43:54.6466845Z    ::: src/librustc_apfloat/lib.rs:48:1
2019-10-13T15:43:54.6467002Z     |
2019-10-13T15:43:54.6467232Z 48  | /      bitflags::bitflags! {
---
2019-10-13T15:43:55.3795765Z == clock drift check ==
2019-10-13T15:43:55.3813761Z   local time: Sun Oct 13 15:43:55 UTC 2019
2019-10-13T15:43:55.5441841Z   network time: Sun, 13 Oct 2019 15:43:55 GMT
2019-10-13T15:43:55.5446787Z == end clock drift check ==
2019-10-13T15:43:56.7135732Z ##[error]Bash exited with code '1'.
2019-10-13T15:43:56.7183164Z ##[section]Starting: Checkout
2019-10-13T15:43:56.7184854Z ==============================================================================
2019-10-13T15:43:56.7184898Z Task         : Get sources
2019-10-13T15:43:56.7185078Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-13T23:38:35.6760634Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-13T23:38:35.6870093Z ##[command]git config gc.auto 0
2019-10-13T23:38:35.6932935Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-13T23:38:35.6992855Z ##[command]git config --get-all http.proxy
2019-10-13T23:38:35.7162683Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65294/merge:refs/remotes/pull/65294/merge
---
2019-10-14T00:40:07.8030682Z .................................................................................................... 1600/9175
2019-10-14T00:40:14.2316313Z .................................................................................................... 1700/9175
2019-10-14T00:40:26.6778057Z ......................i...............i............................................................. 1800/9175
2019-10-14T00:40:34.0136925Z .................................................................................................... 1900/9175
2019-10-14T00:40:48.8198990Z .............iiiii.................................................................................. 2000/9175
2019-10-14T00:40:59.3390521Z .................................................................................................... 2200/9175
2019-10-14T00:41:01.9633229Z .................................................................................................... 2300/9175
2019-10-14T00:41:07.5900858Z .................................................................................................... 2400/9175
2019-10-14T00:41:29.9198359Z .................................................................................................... 2500/9175
---
2019-10-14T00:44:29.8274627Z ....................i...............i............................................................... 4800/9175
2019-10-14T00:44:41.7384587Z .................................................................................................... 4900/9175
2019-10-14T00:44:48.2396741Z .................................................................................................... 5000/9175
2019-10-14T00:44:59.1503684Z .................................................................................................... 5100/9175
2019-10-14T00:45:05.5319276Z ....................ii.ii........................................................................... 5200/9175
2019-10-14T00:45:16.2358033Z .................................................................................................... 5400/9175
2019-10-14T00:45:26.4613172Z ........................................................................................i........... 5500/9175
2019-10-14T00:45:34.7260214Z .................................................................................................... 5600/9175
2019-10-14T00:45:39.9390237Z .................................................................................................... 5700/9175
2019-10-14T00:45:39.9390237Z .................................................................................................... 5700/9175
2019-10-14T00:45:50.7948554Z .....................................................................................ii...i..ii..... 5800/9175
2019-10-14T00:46:16.0253550Z .................................................................................................... 6000/9175
2019-10-14T00:46:26.2531525Z .................................................................................................... 6100/9175
2019-10-14T00:46:26.2531525Z .................................................................................................... 6100/9175
2019-10-14T00:46:35.3989152Z ............................................................................................i..ii... 6200/9175
2019-10-14T00:47:05.2018432Z .................................................................................................... 6400/9175
2019-10-14T00:47:10.4920845Z .....................................................i.............................................. 6500/9175
2019-10-14T00:47:12.7341639Z .................................................................................................... 6600/9175
2019-10-14T00:47:15.2710733Z ..........................i......................................................................... 6700/9175
---
2019-10-14T00:48:21.8197319Z ...................................................................................FFF.............. 7400/9175
2019-10-14T00:48:28.6921620Z .................................................................................................... 7500/9175
2019-10-14T00:48:39.1873626Z .................................................................................................... 7600/9175
2019-10-14T00:48:48.8141059Z .................................................................................................... 7700/9175
2019-10-14T00:48:55.7796659Z ..ii......i......................................................................................... 7800/9175
2019-10-14T00:49:18.3120744Z .................................................................................................... 8000/9175
2019-10-14T00:49:27.6418504Z .................................................................................................... 8100/9175
2019-10-14T00:49:35.9199895Z .................................................................................................... 8200/9175
2019-10-14T00:50:16.5690708Z .................................................................................................... 8300/9175
---
2019-10-14T00:51:31.5772980Z +   --> $DIR/error-with-trait-decl.rs:4:5
2019-10-14T00:51:31.5773178Z +    |
2019-10-14T00:51:31.5773343Z + LL |     #[track_caller]
2019-10-14T00:51:31.5773484Z +    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5773623Z + LL |     fn unwrap(&self);
2019-10-14T00:51:31.5774029Z +    |     ----------------- not a function
2019-10-14T00:51:31.5774371Z 9 error[E0738]: `#[track_caller]` is not supported in trait declarations.
2019-10-14T00:51:31.5774772Z 10   --> $DIR/error-with-trait-decl.rs:4:5
2019-10-14T00:51:31.5774967Z 11    |
2019-10-14T00:51:31.5775087Z 
---
2019-10-14T00:51:31.5777155Z 18 
2019-10-14T00:51:31.5777294Z 
2019-10-14T00:51:31.5777419Z 
2019-10-14T00:51:31.5777563Z The actual stderr differed from the expected stderr.
2019-10-14T00:51:31.5778050Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-decl/error-with-trait-decl.stderr
2019-10-14T00:51:31.5778514Z To update references, rerun the tests and pass the `--bless` flag
2019-10-14T00:51:31.5778993Z To only update this specific test, also pass `--test-args rfc-2091-track-caller/error-with-trait-decl.rs`
2019-10-14T00:51:31.5779333Z error: 1 errors occurred comparing output.
2019-10-14T00:51:31.5779475Z status: exit code: 1
2019-10-14T00:51:31.5779475Z status: exit code: 1
2019-10-14T00:51:31.5780572Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-decl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-decl" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-decl/auxiliary" "-A" "unused"
2019-10-14T00:51:31.5781674Z ------------------------------------------
2019-10-14T00:51:31.5781930Z 
2019-10-14T00:51:31.5782390Z ------------------------------------------
2019-10-14T00:51:31.5782592Z stderr:
2019-10-14T00:51:31.5782592Z stderr:
2019-10-14T00:51:31.5782961Z ------------------------------------------
2019-10-14T00:51:31.5783177Z warning: the feature `track_caller` is incomplete and may cause the compiler to crash
2019-10-14T00:51:31.5783613Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-decl.rs:1:12
2019-10-14T00:51:31.5783830Z    |
2019-10-14T00:51:31.5783998Z LL | #![feature(track_caller)] //~ WARN the feature `track_caller` is incomplete
2019-10-14T00:51:31.5784294Z    |
2019-10-14T00:51:31.5784438Z    = note: `#[warn(incomplete_features)]` on by default
2019-10-14T00:51:31.5784560Z 
2019-10-14T00:51:31.5784711Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5784711Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5785140Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-decl.rs:4:5
2019-10-14T00:51:31.5785329Z    |
2019-10-14T00:51:31.5785484Z LL |     #[track_caller]
2019-10-14T00:51:31.5785626Z    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5785766Z LL |     fn unwrap(&self);
2019-10-14T00:51:31.5786143Z    |     ----------------- not a function
2019-10-14T00:51:31.5786458Z error[E0738]: `#[track_caller]` is not supported in trait declarations.
2019-10-14T00:51:31.5786874Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-decl.rs:4:5
2019-10-14T00:51:31.5787075Z    |
2019-10-14T00:51:31.5787214Z LL |     #[track_caller]
---
2019-10-14T00:51:31.5791933Z +   --> $DIR/error-with-trait-default-impl.rs:4:5
2019-10-14T00:51:31.5792210Z +    |
2019-10-14T00:51:31.5792352Z + LL |     #[track_caller]
2019-10-14T00:51:31.5792506Z +    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5792646Z + LL |     fn unwrap(&self) {}
2019-10-14T00:51:31.5793028Z +    |     ------------------- not a function
2019-10-14T00:51:31.5793399Z 9 error[E0738]: `#[track_caller]` is not supported in trait declarations.
2019-10-14T00:51:31.5793781Z 10   --> $DIR/error-with-trait-default-impl.rs:4:5
2019-10-14T00:51:31.5793998Z 11    |
2019-10-14T00:51:31.5794119Z 
---
2019-10-14T00:51:31.5795888Z 18 
2019-10-14T00:51:31.5796009Z 
2019-10-14T00:51:31.5796127Z 
2019-10-14T00:51:31.5796268Z The actual stderr differed from the expected stderr.
2019-10-14T00:51:31.5796772Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-default-impl/error-with-trait-default-impl.stderr
2019-10-14T00:51:31.5797359Z To update references, rerun the tests and pass the `--bless` flag
2019-10-14T00:51:31.5798067Z To only update this specific test, also pass `--test-args rfc-2091-track-caller/error-with-trait-default-impl.rs`
2019-10-14T00:51:31.5799422Z error: 1 errors occurred comparing output.
2019-10-14T00:51:31.5799467Z status: exit code: 1
2019-10-14T00:51:31.5799467Z status: exit code: 1
2019-10-14T00:51:31.5800371Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-default-impl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-default-impl" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-default-impl/auxiliary" "-A" "unused"
2019-10-14T00:51:31.5800739Z ------------------------------------------
2019-10-14T00:51:31.5800790Z 
2019-10-14T00:51:31.5801014Z ------------------------------------------
2019-10-14T00:51:31.5801059Z stderr:
2019-10-14T00:51:31.5801059Z stderr:
2019-10-14T00:51:31.5801744Z ------------------------------------------
2019-10-14T00:51:31.5801824Z warning: the feature `track_caller` is incomplete and may cause the compiler to crash
2019-10-14T00:51:31.5802194Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-default-impl.rs:1:12
2019-10-14T00:51:31.5802276Z    |
2019-10-14T00:51:31.5802325Z LL | #![feature(track_caller)] //~ WARN the feature `track_caller` is incomplete
2019-10-14T00:51:31.5802431Z    |
2019-10-14T00:51:31.5802476Z    = note: `#[warn(incomplete_features)]` on by default
2019-10-14T00:51:31.5802507Z 
2019-10-14T00:51:31.5802552Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5802552Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5802854Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-default-impl.rs:4:5
2019-10-14T00:51:31.5802903Z    |
2019-10-14T00:51:31.5802944Z LL |     #[track_caller]
2019-10-14T00:51:31.5803004Z    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5803048Z LL |     fn unwrap(&self) {}
2019-10-14T00:51:31.5803274Z    |     ------------------- not a function
2019-10-14T00:51:31.5803368Z error[E0738]: `#[track_caller]` is not supported in trait declarations.
2019-10-14T00:51:31.5803635Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-default-impl.rs:4:5
2019-10-14T00:51:31.5803852Z    |
2019-10-14T00:51:31.5803911Z LL |     #[track_caller]
---
2019-10-14T00:51:31.5805457Z +   --> $DIR/error-with-trait-fn-impl.rs:8:5
2019-10-14T00:51:31.5805512Z +    |
2019-10-14T00:51:31.5805568Z + LL |     #[track_caller]
2019-10-14T00:51:31.5805610Z +    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5805653Z + LL |     fn unwrap(&self) {}
2019-10-14T00:51:31.5805883Z +    |     ------------------- not a function
2019-10-14T00:51:31.5805988Z 9 error[E0738]: `#[track_caller]` is not supported in traits yet.
2019-10-14T00:51:31.5806312Z 10   --> $DIR/error-with-trait-fn-impl.rs:8:5
2019-10-14T00:51:31.5806387Z 11    |
2019-10-14T00:51:31.5806413Z 
---
2019-10-14T00:51:31.5807208Z 18 
2019-10-14T00:51:31.5807243Z 
2019-10-14T00:51:31.5807285Z 
2019-10-14T00:51:31.5807329Z The actual stderr differed from the expected stderr.
2019-10-14T00:51:31.5807666Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl/error-with-trait-fn-impl.stderr
2019-10-14T00:51:31.5807940Z To update references, rerun the tests and pass the `--bless` flag
2019-10-14T00:51:31.5808271Z To only update this specific test, also pass `--test-args rfc-2091-track-caller/error-with-trait-fn-impl.rs`
2019-10-14T00:51:31.5808376Z error: 1 errors occurred comparing output.
2019-10-14T00:51:31.5808421Z status: exit code: 1
2019-10-14T00:51:31.5808421Z status: exit code: 1
2019-10-14T00:51:31.5809234Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl/auxiliary" "-A" "unused"
2019-10-14T00:51:31.5809613Z ------------------------------------------
2019-10-14T00:51:31.5809664Z 
2019-10-14T00:51:31.5809909Z ------------------------------------------
2019-10-14T00:51:31.5809957Z stderr:
2019-10-14T00:51:31.5809957Z stderr:
2019-10-14T00:51:31.5810192Z ------------------------------------------
2019-10-14T00:51:31.5810263Z warning: the feature `track_caller` is incomplete and may cause the compiler to crash
2019-10-14T00:51:31.5810554Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl.rs:1:12
2019-10-14T00:51:31.5810622Z    |
2019-10-14T00:51:31.5810674Z LL | #![feature(track_caller)] //~ WARN the feature `track_caller` is incomplete
2019-10-14T00:51:31.5810876Z    |
2019-10-14T00:51:31.5810941Z    = note: `#[warn(incomplete_features)]` on by default
2019-10-14T00:51:31.5810973Z 
2019-10-14T00:51:31.5811019Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5811019Z error[E0739]: attribute should be applied to function
2019-10-14T00:51:31.5811741Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl.rs:8:5
2019-10-14T00:51:31.5811819Z    |
2019-10-14T00:51:31.5811862Z LL |     #[track_caller]
2019-10-14T00:51:31.5811904Z    |     ^^^^^^^^^^^^^^^
2019-10-14T00:51:31.5811962Z LL |     fn unwrap(&self) {}
2019-10-14T00:51:31.5812260Z    |     ------------------- not a function
2019-10-14T00:51:31.5812357Z error[E0738]: `#[track_caller]` is not supported in traits yet.
2019-10-14T00:51:31.5812627Z   --> /checkout/src/test/ui/rfc-2091-track-caller/error-with-trait-fn-impl.rs:8:5
2019-10-14T00:51:31.5812675Z    |
2019-10-14T00:51:31.5812716Z LL |     #[track_caller]
---
2019-10-14T00:51:31.5833604Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-14T00:51:31.5833706Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-14T00:51:31.5835500Z 
2019-10-14T00:51:31.5835574Z 
2019-10-14T00:51:31.5837513Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-14T00:51:31.5837814Z 
2019-10-14T00:51:31.5837843Z 
2019-10-14T00:51:31.5845178Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-14T00:51:31.5845279Z Build completed unsuccessfully in 1:06:29
2019-10-14T00:51:31.5845279Z Build completed unsuccessfully in 1:06:29
2019-10-14T00:51:31.5899347Z == clock drift check ==
2019-10-14T00:51:31.5920785Z   local time: Mon Oct 14 00:51:31 UTC 2019
2019-10-14T00:51:31.8700156Z   network time: Mon, 14 Oct 2019 00:51:31 GMT
2019-10-14T00:51:31.8703886Z == end clock drift check ==
2019-10-14T00:51:32.3063043Z ##[error]Bash exited with code '1'.
2019-10-14T00:51:32.3111386Z ##[section]Starting: Checkout
2019-10-14T00:51:32.3130585Z ==============================================================================
2019-10-14T00:51:32.3130644Z Task         : Get sources
2019-10-14T00:51:32.3130708Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:lint-inline-prototype branch from 8efdaee to 15c5973 Oct 14, 2019
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 14, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-14T14:10:29.3633864Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-14T14:10:29.3644869Z ##[command]git config gc.auto 0
2019-10-14T14:10:29.3710388Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-14T14:10:29.3764279Z ##[command]git config --get-all http.proxy
2019-10-14T14:10:29.3907495Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65294/merge:refs/remotes/pull/65294/merge
---
2019-10-14T15:12:17.8934267Z .................................................................................................... 1600/9180
2019-10-14T15:12:23.3539540Z .................................................................................................... 1700/9180
2019-10-14T15:12:36.9182496Z .........................i...............i.......................................................... 1800/9180
2019-10-14T15:12:44.2891595Z .................................................................................................... 1900/9180
2019-10-14T15:12:59.0940901Z ................iiiii............................................................................... 2000/9180
2019-10-14T15:13:09.7902807Z .................................................................................................... 2200/9180
2019-10-14T15:13:12.4674277Z .................................................................................................... 2300/9180
2019-10-14T15:13:18.1568019Z .................................................................................................... 2400/9180
2019-10-14T15:13:40.5288238Z .................................................................................................... 2500/9180
---
2019-10-14T15:16:41.3254279Z ........................i...............i........................................................... 4800/9180
2019-10-14T15:16:53.6081039Z .................................................................................................... 4900/9180
2019-10-14T15:17:00.0756328Z .................................................................................................... 5000/9180
2019-10-14T15:17:09.7050048Z .................................................................................................... 5100/9180
2019-10-14T15:17:17.3554450Z ........................ii.ii....................................................................... 5200/9180
2019-10-14T15:17:27.6295725Z .................................................................................................... 5400/9180
2019-10-14T15:17:38.2333665Z ............................................................................................i....... 5500/9180
2019-10-14T15:17:46.6933554Z .................................................................................................... 5600/9180
2019-10-14T15:17:51.6518185Z .................................................................................................... 5700/9180
2019-10-14T15:17:51.6518185Z .................................................................................................... 5700/9180
2019-10-14T15:18:02.6283157Z .........................................................................................ii...i...ii 5800/9180
2019-10-14T15:18:28.6235103Z .................................................................................................... 6000/9180
2019-10-14T15:18:38.7311157Z .................................................................................................... 6100/9180
2019-10-14T15:18:48.1088747Z ................................................................................................i..i 6200/9180
2019-10-14T15:19:03.1274568Z i................................................................................................... 6300/9180
---
2019-10-14T15:24:11.6013144Z  finished in 5.660
2019-10-14T15:24:11.6230867Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:24:11.7953156Z 
2019-10-14T15:24:11.7954076Z running 153 tests
2019-10-14T15:24:15.1221411Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-14T15:24:17.1706992Z i..iiii..............i.........iii.i.........ii......
2019-10-14T15:24:17.1711135Z 
2019-10-14T15:24:17.1712767Z  finished in 5.548
2019-10-14T15:24:17.1906487Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:24:17.3502850Z 
---
2019-10-14T15:24:19.4342092Z  finished in 2.243
2019-10-14T15:24:19.4549719Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:24:19.6154282Z 
2019-10-14T15:24:19.6154627Z running 9 tests
2019-10-14T15:24:19.6155599Z iiiiiiiii
2019-10-14T15:24:19.6155993Z 
2019-10-14T15:24:19.6156040Z  finished in 0.160
2019-10-14T15:24:19.6369790Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:24:19.8047906Z 
---
2019-10-14T15:24:38.4522808Z  finished in 18.815
2019-10-14T15:24:38.4749393Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:24:38.6502428Z 
2019-10-14T15:24:38.6502719Z running 123 tests
2019-10-14T15:25:03.5129950Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-14T15:25:08.3347789Z i.i.i......iii.i.....ii
2019-10-14T15:25:08.3349326Z 
2019-10-14T15:25:08.3350259Z  finished in 29.860
2019-10-14T15:25:08.3364529Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:25:08.3366379Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-14T15:38:35.6800633Z 
2019-10-14T15:38:35.6801414Z    Doc-tests core
2019-10-14T15:38:40.9121050Z 
2019-10-14T15:38:40.9121877Z running 2405 tests
2019-10-14T15:38:52.6234448Z ......iiiii......................................................................................... 100/2405
2019-10-14T15:39:03.9121977Z ...............................................................................ii................... 200/2405
2019-10-14T15:39:30.6195951Z .i.................................................................................................. 400/2405
2019-10-14T15:39:30.6195951Z .i.................................................................................................. 400/2405
2019-10-14T15:39:42.2230579Z ................................................i..i.................iiii........................... 500/2405
2019-10-14T15:40:03.6363384Z .................................................................................................... 700/2405
2019-10-14T15:40:14.6971383Z .................................................................................................... 800/2405
2019-10-14T15:40:25.9730367Z .................................................................................................... 900/2405
2019-10-14T15:40:37.0412215Z .................................................................................................... 1000/2405
---
2019-10-14T15:44:45.9697273Z ............................................... 300/763
2019-10-14T15:44:45.9705587Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-10-14T15:44:46.0787211Z .................................................................................................... 400/763
2019-10-14T15:44:48.1363590Z .................................................................................................... 500/763
2019-10-14T15:44:48.1630294Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-14T15:44:48.1657256Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-10-14T15:44:48.1665658Z ..thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-14T15:44:48.1688950Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-14T15:44:48.3607930Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-14T15:44:48.3640516Z ....thread '<unnamed>' panicked at '.called `Result::unwrap()` on an `Err` value: RecvError', .src/libcore/result.rs:1165:5
2019-10-14T15:44:48.3696156Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-10-14T15:44:50.4481182Z .....................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-10-14T15:44:50.4489339Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-10-14T15:44:50.4493360Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-10-14T15:44:50.4493846Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-10-14T15:44:59.8764293Z 
2019-10-14T15:44:59.8764659Z running 994 tests
2019-10-14T15:45:22.5324807Z i................................................................................................... 100/994
2019-10-14T15:45:35.0127883Z .................................................................................................... 200/994
2019-10-14T15:45:44.0028388Z ...................iii......i......i...i......i..................................................... 300/994
2019-10-14T15:45:50.0865967Z .................................................................................................... 400/994
2019-10-14T15:45:58.4063536Z .....................................i..i.................................ii........................ 500/994
2019-10-14T15:46:14.2468618Z .................................................................................................... 700/994
2019-10-14T15:46:14.2468618Z .................................................................................................... 700/994
2019-10-14T15:46:22.8993825Z ....................iiii............................................................................ 800/994
2019-10-14T15:46:38.8772027Z .................................................................................................... 900/994
2019-10-14T15:46:46.9484983Z ..........................................iiii................................................
2019-10-14T15:46:46.9489799Z 
2019-10-14T15:46:46.9597834Z  finished in 203.394
2019-10-14T15:46:46.9615979Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-14T15:46:47.1794109Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-10-14T16:01:06.4222193Z     Checking compiler_builtins v0.1.18
2019-10-14T16:01:07.4767845Z  Documenting alloc v0.0.0 (/checkout/src/liballoc)
2019-10-14T16:01:10.7909922Z     Finished release [optimized] target(s) in 24.07s
2019-10-14T16:01:11.1455683Z  Documenting core v0.0.0 (/checkout/src/libcore)
2019-10-14T16:01:15.9097697Z error: attribute should be applied to a function
2019-10-14T16:01:15.9099161Z   --> src/libcore/../stdarch/crates/core_arch/src/powerpc/vsx.rs:61:17
2019-10-14T16:01:15.9099787Z    |
2019-10-14T16:01:15.9100479Z 61 |                   #[target_feature(enable = "vsx")]
2019-10-14T16:01:15.9101100Z    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-14T16:01:15.9101795Z 62 | /                 unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self {
2019-10-14T16:01:15.9102819Z 63 | |                     mem::transmute(xxpermdi(mem::transmute(self), mem::transmute(b), dm))
2019-10-14T16:01:15.9104135Z    | |_________________- not a function
2019-10-14T16:01:15.9105295Z ...
2019-10-14T16:01:15.9105295Z ...
2019-10-14T16:01:15.9105959Z 69 |       vec_xxpermdi! { vector_unsigned_long }
2019-10-14T16:01:15.9106780Z 
2019-10-14T16:01:15.9107216Z error: attribute should be applied to a function
2019-10-14T16:01:15.9107216Z error: attribute should be applied to a function
2019-10-14T16:01:15.9107730Z   --> src/libcore/../stdarch/crates/core_arch/src/powerpc/vsx.rs:61:17
2019-10-14T16:01:15.9108151Z    |
2019-10-14T16:01:15.9108901Z 61 |                   #[target_feature(enable = "vsx")]
2019-10-14T16:01:15.9109543Z    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-14T16:01:15.9110097Z 62 | /                 unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self {
2019-10-14T16:01:15.9110687Z 63 | |                     mem::transmute(xxpermdi(mem::transmute(self), mem::transmute(b), dm))
2019-10-14T16:01:15.9111727Z    | |_________________- not a function
2019-10-14T16:01:15.9112168Z ...
2019-10-14T16:01:15.9112168Z ...
2019-10-14T16:01:15.9112661Z 70 |       vec_xxpermdi! { vector_signed_long }
2019-10-14T16:01:15.9113406Z 
2019-10-14T16:01:15.9113816Z error: attribute should be applied to a function
2019-10-14T16:01:15.9113816Z error: attribute should be applied to a function
2019-10-14T16:01:15.9114380Z   --> src/libcore/../stdarch/crates/core_arch/src/powerpc/vsx.rs:61:17
2019-10-14T16:01:15.9114837Z    |
2019-10-14T16:01:15.9115410Z 61 |                   #[target_feature(enable = "vsx")]
2019-10-14T16:01:15.9115943Z    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-14T16:01:15.9116532Z 62 | /                 unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self {
2019-10-14T16:01:15.9117166Z 63 | |                     mem::transmute(xxpermdi(mem::transmute(self), mem::transmute(b), dm))
2019-10-14T16:01:15.9118954Z    | |_________________- not a function
2019-10-14T16:01:15.9126122Z ...
2019-10-14T16:01:15.9126122Z ...
2019-10-14T16:01:15.9126740Z 71 |       vec_xxpermdi! { vector_bool_long }
2019-10-14T16:01:15.9128299Z 
2019-10-14T16:01:15.9134386Z error: attribute should be applied to a function
2019-10-14T16:01:15.9134386Z error: attribute should be applied to a function
2019-10-14T16:01:15.9135649Z   --> src/libcore/../stdarch/crates/core_arch/src/powerpc/vsx.rs:61:17
2019-10-14T16:01:15.9136115Z    |
2019-10-14T16:01:15.9136647Z 61 |                   #[target_feature(enable = "vsx")]
2019-10-14T16:01:15.9137149Z    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-10-14T16:01:15.9137747Z 62 | /                 unsafe fn vec_xxpermdi(self, b: Self, dm: u8) -> Self {
2019-10-14T16:01:15.9140090Z 63 | |                     mem::transmute(xxpermdi(mem::transmute(self), mem::transmute(b), dm))
2019-10-14T16:01:15.9146725Z    | |_________________- not a function
2019-10-14T16:01:15.9147225Z ...
2019-10-14T16:01:15.9147225Z ...
2019-10-14T16:01:15.9147737Z 72 |       vec_xxpermdi! { vector_double }
2019-10-14T16:01:15.9148848Z 
2019-10-14T16:01:19.0368059Z error: aborting due to 4 previous errors
2019-10-14T16:01:19.0368257Z 
2019-10-14T16:01:19.1393259Z error: Could not document `core`.
2019-10-14T16:01:19.1393259Z error: Could not document `core`.
2019-10-14T16:01:19.1393416Z 
2019-10-14T16:01:19.1393471Z Caused by:
2019-10-14T16:01:19.1394351Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type lib --crate-name core src/libcore/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --color always --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.40.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps` (exit code: 1)
2019-10-14T16:01:19.1403541Z 
2019-10-14T16:01:19.1403541Z 
2019-10-14T16:01:19.1405023Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "core" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.40.0" "--index-page" "/checkout/src/doc/index.md"
2019-10-14T16:01:19.1405546Z 
2019-10-14T16:01:19.1405577Z 
2019-10-14T16:01:19.1410851Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-14T16:01:19.1411135Z Build completed unsuccessfully in 1:44:16
2019-10-14T16:01:19.1411135Z Build completed unsuccessfully in 1:44:16
2019-10-14T16:01:19.1471062Z == clock drift check ==
2019-10-14T16:01:19.1493092Z   local time: Mon Oct 14 16:01:19 UTC 2019
2019-10-14T16:01:19.3109997Z   network time: Mon, 14 Oct 2019 16:01:19 GMT
2019-10-14T16:01:19.3111210Z == end clock drift check ==
2019-10-14T16:01:20.4833077Z ##[error]Bash exited with code '1'.
2019-10-14T16:01:20.4887564Z ##[section]Starting: Checkout
2019-10-14T16:01:20.4889541Z ==============================================================================
2019-10-14T16:01:20.4889597Z Task         : Get sources
2019-10-14T16:01:20.4889644Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 14, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 14, 2019

⌛️ Trying commit 185b013 with merge 38f0837...

bors added a commit that referenced this pull request Oct 14, 2019
Lint ignored `#[inline]` on function prototypes

Fixes #51280.

- Adds a `unused_attribute` lint for `#[inline]` on function prototypes.
- As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 14, 2019

☀️ Try build successful - checks-azure
Build commit: 38f0837 (38f08371587f97c145dedb2c055ac7b01bf1e788)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 14, 2019

@craterbot check

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Oct 14, 2019

👌 Experiment pr-65294 created and queued.
🤖 Automatically detected try build 38f0837
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Oct 21, 2019

🚧 Experiment pr-65294 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Oct 23, 2019

🎉 Experiment pr-65294 is completed!
📊 2540 regressed and 0 fixed (74234 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Copy link
Collaborator

craterbot commented Oct 28, 2019

🎉 Experiment pr-65294-1 is completed!
📊 7 regressed and 0 fixed (2540 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 28, 2019

Triage of regressions from crater run:

  • axgeom uses #[inline] on a type and dinotree and duckduckgo depend on it (all from the same author).
  • saebs has a legitimate error from incorrect use of #[repr(C)].
  • flakebi-ring, rando and ring has #![disallow(warnings)] on.

These all seem like expected and acceptable errors to me. In particular, no downstream crates suffer (apart from those related by the same author, which are easily fixed). I think this is ready for a final review now.

@matthewjasper

This comment has been minimized.

Copy link
Contributor

matthewjasper commented Oct 28, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 28, 2019

📌 Commit f47f530 has been approved by matthewjasper

Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
…thewjasper

Lint ignored `#[inline]` on function prototypes

Fixes rust-lang#51280.

- Adds a `unused_attribute` lint for `#[inline]` on function prototypes.
- As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
bors added a commit that referenced this pull request Oct 29, 2019
Rollup of 8 pull requests

Successful merges:

 - #65068 (Custom lifetime error for `impl` item doesn't conform to `trait`)
 - #65294 (Lint ignored `#[inline]` on function prototypes)
 - #65318 (Call out the types that are non local on E0117)
 - #65531 (Update backtrace to 0.3.40)
 - #65562 (Improve the "try using a variant of the expected type" hint.)
 - #65809 (Add new EFIAPI ABI)
 - #65843 (Enable dist for MIPS64 musl targets)
 - #65859 (Better pretty printing for const raw pointers)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
…thewjasper

Lint ignored `#[inline]` on function prototypes

Fixes rust-lang#51280.

- Adds a `unused_attribute` lint for `#[inline]` on function prototypes.
- As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
bors added a commit that referenced this pull request Oct 29, 2019
Rollup of 6 pull requests

Successful merges:

 - #65294 (Lint ignored `#[inline]` on function prototypes)
 - #65318 (Call out the types that are non local on E0117)
 - #65531 (Update backtrace to 0.3.40)
 - #65562 (Improve the "try using a variant of the expected type" hint.)
 - #65809 (Add new EFIAPI ABI)
 - #65859 (Better pretty printing for const raw pointers)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 29, 2019

⌛️ Testing commit f47f530 with merge a77114b...

bors added a commit that referenced this pull request Oct 29, 2019
Lint ignored `#[inline]` on function prototypes

Fixes #51280.

- Adds a `unused_attribute` lint for `#[inline]` on function prototypes.
- As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
Centril added a commit to Centril/rust that referenced this pull request Oct 29, 2019
…thewjasper

Lint ignored `#[inline]` on function prototypes

Fixes rust-lang#51280.

- Adds a `unused_attribute` lint for `#[inline]` on function prototypes.
- As a consequence, foreign items, impl items and trait items now have their attributes checked, which could cause some code to no longer compile (it was previously erroneously ignored).
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 29, 2019

@bors retry

bors added a commit that referenced this pull request Oct 29, 2019
Rollup of 5 pull requests

Successful merges:

 - #65294 (Lint ignored `#[inline]` on function prototypes)
 - #65318 (Call out the types that are non local on E0117)
 - #65531 (Update backtrace to 0.3.40)
 - #65562 (Improve the "try using a variant of the expected type" hint.)
 - #65809 (Add new EFIAPI ABI)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 29, 2019

⌛️ Testing commit f47f530 with merge 2dd4e73...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 29, 2019

☔️ The latest upstream changes (presumably #65919) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit f47f530 into rust-lang:master Oct 29, 2019
1 check was pending
1 check was pending
homu Testing commit f47f53078c7477d2a2f7739c8f0e295125dd6bd3 with merge 2dd4e7320e620dc9a59423c55a7db3520ba8b553...
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.