Fix suggestion to constrain trait for method to be found #65242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Oct 9, 2019
| } | ||
| _ => { | ||
| has_bounds = !param.bounds.is_empty(); | ||
| debug!("suggest_traits_to_import {:?} {:?}", hir.get(id), generics); |
There was a problem hiding this comment.
The current method is getting rather large; would be good to subdivide things.
There was a problem hiding this comment.
I feel that splitting this method would lead to with smaller methods with too many arguments, beyond the point for to be worth it.
There was a problem hiding this comment.
That suggests that a struct should be invented to carry the additional state.
Centril
reviewed
Oct 9, 2019
|
☔ The latest upstream changes (presumably #65322) made this pull request unmergeable. Please resolve the merge conflicts. |
varkor
reviewed
Oct 13, 2019
|
Looks good. r=me with spelling fix. |
estebank
force-pushed
the
contrain-trait-sugg
branch
from
57f456e
to
dee53d7
Compare
|
Rebased. @bors r=varkor |
|
📌 Commit dee53d7 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
Fix suggestion to constrain trait for method to be found Fix rust-lang#65044.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 15, 2019
Fix suggestion to constrain trait for method to be found Fix rust-lang#65044.
bors
added a commit
that referenced
this pull request
Oct 15, 2019
Rollup of 14 pull requests Successful merges: - #64603 (Reducing spurious unused lifetime warnings.) - #64623 (Remove last uses of gensyms) - #65235 (don't assume we can *always* find a return type hint in async fn) - #65242 (Fix suggestion to constrain trait for method to be found) - #65265 (Cleanup librustc mir err codes) - #65293 (Optimize `try_expand_impl_trait_type`) - #65307 (Try fix incorrect "explicit lifetime name needed") - #65308 (Add long error explanation for E0574) - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members) - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.) - #65402 (Add troubleshooting section to PGO chapter in rustc book.) - #65425 (Optimize `BitIter`) - #65438 (Organize `never_type` tests) - #65444 (Implement AsRef<[T]> for List<T>) Failed merges: - #65390 (Add long error explanation for E0576) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65044.