Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsRef<[T]> for List<T> #65444

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@spastorino
Copy link
Member

spastorino commented Oct 15, 2019

@spastorino spastorino force-pushed the spastorino:as-ref-for-list branch from 16f5d86 to fa3a4ae Oct 15, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 15, 2019

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-15T17:44:07.9423685Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-15T17:44:07.9523894Z ##[command]git config gc.auto 0
2019-10-15T17:44:07.9606526Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-15T17:44:07.9660325Z ##[command]git config --get-all http.proxy
2019-10-15T17:44:07.9824733Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65444/merge:refs/remotes/pull/65444/merge
---
2019-10-15T17:46:24.0952441Z Attempting with retry: docker build --rm -t rust-ci -f /home/vsts/work/1/s/src/ci/docker/mingw-check/Dockerfile /home/vsts/work/1/s/src/ci/docker
2019-10-15T17:46:24.1901750Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:46:24.1903934Z 
2019-10-15T17:46:24.2169356Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:24.6125983Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:46:25.7151765Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:46:25.7151963Z 
2019-10-15T17:46:25.7311909Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:25.7311909Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:26.0007819Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:46:28.1339385Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:46:28.1339627Z 
2019-10-15T17:46:28.1550343Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:28.1550343Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:28.4202955Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:46:31.5482278Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:46:31.5483324Z 
2019-10-15T17:46:31.5706629Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:31.5706629Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:31.8508018Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:46:35.9473740Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:46:35.9474690Z 
2019-10-15T17:46:35.9715312Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:35.9715312Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:46:36.2123373Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:46:36.2138611Z The command has failed after 5 attempts.
2019-10-15T17:46:36.2291589Z ##[error]Bash exited with code '1'.
2019-10-15T17:46:36.2330875Z ##[section]Starting: Checkout
2019-10-15T17:46:36.2332709Z ==============================================================================
2019-10-15T17:46:36.2332807Z Task         : Get sources
2019-10-15T17:46:36.2332853Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Oct 15, 2019

@bors r+ rollup=always

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit fa3a4ae has been approved by Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
…Simulacrum

Implement AsRef<[T]> for List<T>

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 9 pull requests

Successful merges:

 - #65094 (Prefer statx on linux if available)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65435 (Fix #64153)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
…Simulacrum

Implement AsRef<[T]> for List<T>

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 8 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65435 (Fix #64153)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
…Simulacrum

Implement AsRef<[T]> for List<T>

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 14 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #64623 (Remove last uses of gensyms)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65265 (Cleanup librustc mir err codes)
 - #65293 (Optimize `try_expand_impl_trait_type`)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65308 (Add long error explanation for E0574)
 - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members)
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65425 (Optimize `BitIter`)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

 - #65390 (Add long error explanation for E0576)

r? @ghost
@bors bors merged commit fa3a4ae into rust-lang:master Oct 16, 2019
1 of 4 checks passed
1 of 4 checks passed
pr Build #20191015.46 failed
Details
pr (Linux mingw-check) Linux mingw-check failed
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 failed
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.