Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for type X = impl Trait; in lifetime suggestion #67671

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Account for type X = impl Trait; in lifetime suggestion #67671

merged 1 commit into from
Jan 7, 2020

Conversation

estebank
Copy link
Contributor

Fix #67619.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2019
@estebank
Copy link
Contributor Author

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned cramertj Dec 28, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-28T04:10:46.4089749Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-28T04:10:46.9722235Z ##[command]git config gc.auto 0
2019-12-28T04:10:46.9727918Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-28T04:10:46.9730830Z ##[command]git config --get-all http.proxy
2019-12-28T04:10:46.9735074Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67671/merge:refs/remotes/pull/67671/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

davidtwco
davidtwco approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me once CI passes.

@estebank
Copy link
Contributor Author

estebank commented Jan 7, 2020

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jan 7, 2020

📌 Commit 2905f14 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 7, 2020
@JohnTitor
Rollup merge of rust-lang#67671 - estebank:type-impl-trait, r=davidtwco
3cce950 
Account for `type X = impl Trait;` in lifetime suggestion

Fix rust-lang#67619.
@JohnTitor JohnTitor mentioned this pull request Jan 7, 2020
Merged
bors added a commit that referenced this pull request Jan 7, 2020
@bors
Auto merge of #67964 - JohnTitor:rollup-pu5kosl, r=JohnTitor
4f074de 
Rollup of 13 pull requests

Successful merges:

 - #67566 (Add an unstable conversion from thread ID to u64)
 - #67671 (Account for `type X = impl Trait;` in lifetime suggestion)
 - #67727 (Stabilise vec::remove_item)
 - #67877 (Omit underscore constants from rustdoc)
 - #67880 (Handle multiple error fix suggestions carefuly)
 - #67898 (Improve hygiene of `newtype_index`)
 - #67908 (rustdoc: HTML escape const values)
 - #67909 (Fix ICE in const pretty printing and resolve FIXME)
 - #67929 (Formatting an example for method Vec.retain)
 - #67934 (Clean up E0178 explanation)
 - #67936 (fire "non_camel_case_types" for associated types)
 - #67943 (Missing module std in example.)
 - #67962 (Update books)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jan 7, 2020

☔ The latest upstream changes (presumably #67964) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2020
@bors bors merged commit 2905f14 into rust-lang:master Jan 7, 2020
@estebank estebank deleted the type-impl-trait branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad suggestion to restrict lifetime of type = impl Trait
5 participants
@estebank @rust-highfive @bors @davidtwco @cramertj