Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't recurse into types that do not need normalizing #67808

Merged
merged 1 commit into from Jan 5, 2020

Conversation

@Marwes
Copy link
Contributor

Marwes commented Jan 2, 2020

A bit speculative at this stage but profiling shows that type folding
takes up a substantial amount of time during normalization which may
indicate that many types may be folded despite there being nothing to
normalize

A bit speculative at this stage but profiling shows that type folding
takes up a substantial amount of time during normalization which may
indicate that many types may be folded despite there being nothing to
normalize
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 2, 2020

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Jan 2, 2020

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 2, 2020

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

⌛️ Trying commit e6e61d9 with merge 17c274f...

bors added a commit that referenced this pull request Jan 2, 2020
perf: Don't recurse into types that do not need normalizing

A bit speculative at this stage but profiling shows that type folding
takes up a substantial amount of time during normalization which may
indicate that many types may be folded despite there being nothing to
normalize
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

☀️ Try build successful - checks-azure
Build commit: 17c274f (17c274f7c489ac0008d466793d34ea6d48dbd8a4)

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 2, 2020

Queued 17c274f with parent 0a58f58, future comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 2, 2020

Finished benchmarking try commit 17c274f, comparison URL.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 2, 2020

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 3, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 3, 2020

📌 Commit e6e61d9 has been approved by nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 5, 2020

⌛️ Testing commit e6e61d9 with merge 093241d...

bors added a commit that referenced this pull request Jan 5, 2020
…omatsakis

perf: Don't recurse into types that do not need normalizing

A bit speculative at this stage but profiling shows that type folding
takes up a substantial amount of time during normalization which may
indicate that many types may be folded despite there being nothing to
normalize
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 5, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 093241d to master...

@bors bors added the merged-by-bors label Jan 5, 2020
@bors bors merged commit e6e61d9 into rust-lang:master Jan 5, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200102.25 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 5, 2020

📣 Toolstate changed by #67808!

Tested on commit 093241d.
Direct link to PR: #67808

💔 rustc-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 5, 2020
Tested on commit rust-lang/rust@093241d.
Direct link to PR: <rust-lang/rust#67808>

💔 rustc-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
@Marwes Marwes deleted the Marwes:projection_normalization_recurse branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.