Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the debug_map_key_value feature #68200

Open
wants to merge 1 commit into
base: master
from

Conversation

@KodrAus
Copy link
Contributor

KodrAus commented Jan 14, 2020

RFC: rust-lang/rfcs#2696
Tracking issue: #62482

Stabilizes the debug_map_key_value feature, which covers:

impl<'a, 'b> DebugMap<'a, 'b> {
    pub fn key(&mut self, key: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
    pub fn value(&mut self, value: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
}

These methods are small and self-contained, and are used as the basis for the existing DebugMap::entry method, so have been used in the wild for the last 6 months or so.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 14, 2020

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@KodrAus

This comment has been minimized.

Copy link
Contributor Author

KodrAus commented Jan 14, 2020

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jan 14, 2020

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Jan 14, 2020

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jan 14, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2020

☔️ The latest upstream changes (presumably #66716) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.