Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_match: extract common logic #68571

Merged
merged 1 commit into from Jan 28, 2020
Merged

check_match: extract common logic #68571

merged 1 commit into from Jan 28, 2020

Conversation

@Centril
Copy link
Member

Centril commented Jan 27, 2020

This is part of work on hir::ExprKind::Let which I thought made sense on its own (though makes even more sense with ::Let).

r? @oli-obk

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Jan 27, 2020

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 27, 2020

📌 Commit de7f16d has been approved by oli-obk

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 28, 2020
check_match: extract common logic

This is part of work on `hir::ExprKind::Let` which I thought made sense on its own (though makes even more sense with `::Let`).

r? @oli-obk
bors added a commit that referenced this pull request Jan 28, 2020
Rollup of 11 pull requests

Successful merges:

 - #68200 (Stabilize the debug_map_key_value feature)
 - #68383 (Clean up E0205 explanation)
 - #68412 (Clean up E0207 explanation)
 - #68454 (clean up E0214 explanation)
 - #68482 (clean up error codes explanation)
 - #68563 (Don't call `tcx.fn_sig` on closures)
 - #68570 (Bump LLVM submodule to fix LLVM assertion failure in MSP430 interrupt generation.)
 - #68571 (check_match: extract common logic)
 - #68573 (Clean up E0262 explanation)
 - #68575 (Disable the testcase for Vxworks.)
 - #68581 (Add support for icebreakers-cleanup-crew commands)

Failed merges:

r? @ghost
@bors bors merged commit de7f16d into rust-lang:master Jan 28, 2020
4 checks passed
4 checks passed
pr Build #20200127.19 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril Centril deleted the Centril:check_in_cx branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.