VecMap::get_value_matching should return just one element #86410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
95a327b
to
3b1b584
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
3b1b584
to
bae8e68
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
bae8e68
to
50cc3de
Compare
This comment has been minimized.
This comment has been minimized.
nikomatsakis
requested changes
Jun 23, 2021
spastorino
force-pushed
the
get_value_matching
branch
3 times, most recently
from
662b6c4
to
3aa79a3
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
3aa79a3
to
21fd769
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
21fd769
to
ce4e0b4
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
ce4e0b4
to
482db08
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
482db08
to
87fa875
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
get_value_matching
branch
from
87fa875
to
16c9ba2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spastorino
commented
Jul 6, 2021
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
get_value_matching
branch
from
113bd9a
to
ac32b5e
Compare
oli-obk
reviewed
Jul 13, 2021
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 16, 2021
Loop over all opaque types instead of looking at just the first one with the same DefId This exposed a bug in VecMap and is needed for rust-lang#86410 anyway r? `@spastorino` cc `@nikomatsakis`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 16, 2021
Loop over all opaque types instead of looking at just the first one with the same DefId This exposed a bug in VecMap and is needed for rust-lang#86410 anyway r? ``@spastorino`` cc ``@nikomatsakis``
|
☔ The latest upstream changes (presumably #87141) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @oli-obk |
spastorino
force-pushed
the
get_value_matching
branch
from
9918f4d
to
09b9a69
Compare
spastorino
added
S-blocked
spastorino
force-pushed
the
get_value_matching
branch
from
09b9a69
to
914b592
Compare
Otherwise is a bug that we want to uncover.
spastorino
force-pushed
the
get_value_matching
branch
from
914b592
to
07cd317
Compare
spastorino
force-pushed
the
get_value_matching
branch
2 times, most recently
from
56e1f1e
to
c79df85
Compare
|
@bors r+ |
|
📌 Commit c79df85 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=always |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#86410 (VecMap::get_value_matching should return just one element) - rust-lang#86790 (Document iteration order of `retain` functions) - rust-lang#87171 (Remove Option from BufWriter) - rust-lang#87175 (Stabilize `into_parts()` and `into_error()`) - rust-lang#87185 (Fix panics on Windows when the build was cancelled) - rust-lang#87191 (Package LLVM libs for the target rather than the build host) - rust-lang#87255 (better support for running libcore tests with Miri) - rust-lang#87266 (Add testcase for 87076) - rust-lang#87283 (Add `--codegen-backends=foo,bar` configure flag) - rust-lang#87322 (fix: clarify suggestion that `&T` must refer to `T: Sync` for `&T: Send`) - rust-lang#87358 (Fix `--dry-run` when download-ci-llvm is set) - rust-lang#87380 (Don't default to `submodules = true` unless the rust repo has a .git directory) - rust-lang#87398 (Add test for fonts used for module items) - rust-lang#87412 (Add missing article) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
Related to #86465 and #87287