Stabilize `const_ptr_offset_from`. #96240

fee1-dead · 2022-04-20T04:43:52Z

Stabilization has been completed here with a FCP.

rust-highfive · 2022-04-20T04:43:54Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-04-20T04:43:56Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

fee1-dead · 2022-04-20T04:44:47Z

r? rust-lang/libs-api

@rustbot label +T-libs-api +T-lang -T-libs

bors · 2022-05-12T05:10:35Z

☔ The latest upstream changes (presumably #95837) made this pull request unmergeable. Please resolve the merge conflicts.

coolreader18 · 2022-05-20T06:48:16Z

Is there an update for this?

jhpratt

Other than bumping the version to 1.63, LGTM.

fee1-dead · 2022-05-22T23:02:46Z

bumped.

bors · 2022-05-29T19:38:40Z

☔ The latest upstream changes (presumably #97214) made this pull request unmergeable. Please resolve the merge conflicts.

fee1-dead · 2022-06-04T13:22:00Z

(deleted)

fee1-dead · 2022-07-24T09:57:33Z

r? rust-lang/libs

klensy · 2022-07-24T10:36:32Z

library/core/src/intrinsics.rs

@@ -1903,11 +1903,11 @@ extern "rust-intrinsic" {
    pub fn nontemporal_store<T>(ptr: *mut T, val: T);

    /// See documentation of `<*const T>::offset_from` for details.
-    #[rustc_const_unstable(feature = "const_ptr_offset_from", issue = "92980")]
+    #[rustc_const_stable(feature = "const_ptr_offset_from", since = "1.63.0")]


1.64.0 here and lower?

rustbot · 2022-07-24T10:43:50Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

coolreader18 · 2022-08-24T18:32:39Z

Sorry to bump this again, but I think this stabilization is super exciting and important, since it finally allows for const offsetof(Foo.bar) calculations. I think by this point it should be stable since = "1.65.0" since 1.63 has been released, but could someone from the libs-api team (@jhpratt?) take a look at it after? The FCP was completed 5+ months ago at this point.

jhpratt · 2022-08-24T18:35:25Z

I'm not on T-libs-api, but I'll take another look at it in the near future.

jhpratt

As with before, diff LGTM. Just needs the version bumped to 1.65, naturally.

Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP.

Mark-Simulacrum · 2022-08-27T00:27:21Z

@bors r+ rollup

bors · 2022-08-27T00:27:23Z

📌 Commit 69ad634 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…ffset_from, r=Mark-Simulacrum Stabilize `const_ptr_offset_from`. Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP. Closes rust-lang#92980.

Rollup of 11 pull requests Successful merges: - rust-lang#96240 (Stabilize `const_ptr_offset_from`.) - rust-lang#99784 (Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default) - rust-lang#100811 (Fix wrong compiletest filters on Windows) - rust-lang#100924 (Smaller improvements of tidy and the unicode generator) - rust-lang#100953 (Update documentation for `write!` and `writeln!`) - rust-lang#101018 (rustdoc: omit start/end tags for empty item description blocks) - rust-lang#101044 (rustdoc: remove unused CSS for `hidden-by-*-hider`) - rust-lang#101046 (rustdoc: remove incorrect CSS selector `.impl-items table td`) - rust-lang#101057 (Merge implementations of HIR fn_decl and fn_sig.) - rust-lang#101062 (rustdoc: remove empty extern_crates and type="text/javascript" on script) - rust-lang#101063 (Merge duplicated CSS rules) Failed merges: - rust-lang#101055 (Use smaller span for suggestions) r? `@ghost` `@rustbot` modify labels: rollup

…et_from)]` The `const_ptr_offset_from` feature was stabilized by [rust-lang/rust#96240][1]. [1]: rust-lang/rust#96240

rust-highfive assigned m-ou-se Apr 20, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 20, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022

rust-highfive assigned joshtriplett Apr 20, 2022

rustbot added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 20, 2022

rust-highfive unassigned m-ou-se Apr 20, 2022

rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 20, 2022

This comment has been minimized.

Sign in to view

fee1-dead force-pushed the stabilize_const_offset_from branch 2 times, most recently from 85a8c2c to acef376 Compare April 21, 2022 09:32

ojeda mentioned this pull request Apr 21, 2022

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

76 tasks

fee1-dead force-pushed the stabilize_const_offset_from branch from acef376 to 77f5bb4 Compare May 12, 2022 06:34

This comment has been minimized.

Sign in to view

fee1-dead force-pushed the stabilize_const_offset_from branch from a36e998 to c182720 Compare May 12, 2022 07:49

jhpratt reviewed May 21, 2022

View reviewed changes

fee1-dead force-pushed the stabilize_const_offset_from branch from c182720 to 0030103 Compare May 22, 2022 22:19

fee1-dead assigned m-ou-se and unassigned joshtriplett Jun 4, 2022

fee1-dead added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 4, 2022

fee1-dead force-pushed the stabilize_const_offset_from branch from 0030103 to c886f1d Compare June 4, 2022 13:32

rust-highfive assigned kennytm and unassigned m-ou-se Jul 24, 2022

klensy reviewed Jul 24, 2022

View reviewed changes

fee1-dead force-pushed the stabilize_const_offset_from branch from c886f1d to 0f013f1 Compare July 24, 2022 10:43

jhpratt approved these changes Aug 24, 2022

View reviewed changes

Mark-Simulacrum assigned Mark-Simulacrum and unassigned kennytm Aug 24, 2022

fee1-dead force-pushed the stabilize_const_offset_from branch from 0f013f1 to 9c1bb80 Compare August 25, 2022 03:13

This comment has been minimized.

Sign in to view

fee1-dead added 2 commits August 25, 2022 06:03

Stabilize const_ptr_offset_from.

ad93272

Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP.

Do not include const_ptr_sub_ptr in this stabilization

69ad634

fee1-dead force-pushed the stabilize_const_offset_from branch from 9c1bb80 to 69ad634 Compare August 25, 2022 06:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2022

compiler-errors mentioned this pull request Aug 27, 2022

Rollup of 12 pull requests #101073

Closed

JohnTitor mentioned this pull request Aug 27, 2022

Rollup of 11 pull requests #101074

Merged

bors merged commit 539e408 into rust-lang:master Aug 27, 2022

rustbot added this to the 1.65.0 milestone Aug 27, 2022

coolreader18 mentioned this pull request Sep 1, 2022

Add core::mem::offset_of! RFC rust-lang/rfcs#3308

Merged

fee1-dead deleted the stabilize_const_offset_from branch September 3, 2022 16:44

yvt added a commit to r3-os/r3 that referenced this pull request Nov 12, 2022

refactor(core,port_arm,port_arm_m): remove `#![feature(const_ptr_offs…

3867f05

…et_from)]` The `const_ptr_offset_from` feature was stabilized by [rust-lang/rust#96240][1]. [1]: rust-lang/rust#96240

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize `const_ptr_offset_from`. #96240

Stabilize `const_ptr_offset_from`. #96240

fee1-dead commented Apr 20, 2022

rust-highfive commented Apr 20, 2022

rust-highfive commented Apr 20, 2022

fee1-dead commented Apr 20, 2022

This comment has been minimized.

bors commented May 12, 2022

This comment has been minimized.

This comment has been minimized.

coolreader18 commented May 20, 2022

jhpratt left a comment

fee1-dead commented May 22, 2022

bors commented May 29, 2022

fee1-dead commented Jun 4, 2022 •

edited

Loading

fee1-dead commented Jul 24, 2022

klensy Jul 24, 2022

fee1-dead Jul 27, 2022

rustbot commented Jul 24, 2022

coolreader18 commented Aug 24, 2022

jhpratt commented Aug 24, 2022

jhpratt left a comment

This comment has been minimized.

Mark-Simulacrum commented Aug 27, 2022

bors commented Aug 27, 2022

Stabilize const_ptr_offset_from. #96240

Stabilize const_ptr_offset_from. #96240

Conversation

fee1-dead commented Apr 20, 2022

rust-highfive commented Apr 20, 2022

rust-highfive commented Apr 20, 2022

fee1-dead commented Apr 20, 2022

This comment has been minimized.

bors commented May 12, 2022

This comment has been minimized.

This comment has been minimized.

coolreader18 commented May 20, 2022

jhpratt left a comment

Choose a reason for hiding this comment

fee1-dead commented May 22, 2022

bors commented May 29, 2022

fee1-dead commented Jun 4, 2022 • edited Loading

fee1-dead commented Jul 24, 2022

klensy Jul 24, 2022

Choose a reason for hiding this comment

fee1-dead Jul 27, 2022

Choose a reason for hiding this comment

rustbot commented Jul 24, 2022

coolreader18 commented Aug 24, 2022

jhpratt commented Aug 24, 2022

jhpratt left a comment

Choose a reason for hiding this comment

This comment has been minimized.

Mark-Simulacrum commented Aug 27, 2022

bors commented Aug 27, 2022

Stabilize `const_ptr_offset_from`. #96240

Stabilize `const_ptr_offset_from`. #96240

fee1-dead commented Jun 4, 2022 •

edited

Loading