Skip to content

Move most flags from module_codegen to new_context#868

Merged
antoyo merged 3 commits intorust-lang:masterfrom
bjorn3:misc_changes
Apr 30, 2026
Merged

Move most flags from module_codegen to new_context#868
antoyo merged 3 commits intorust-lang:masterfrom
bjorn3:misc_changes

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Apr 1, 2026

This way they also apply to the allocator shim. Also remove a todo.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this and thanks for this nice improvement.
One nitpick to fix:

View changes since this review

Comment thread src/gcc_util.rs Outdated
bjorn3 added 3 commits April 30, 2026 15:58
This way they also apply to the allocator shim.
Submission to the Apple App Store for iOS no longer requires embedding
bitcode, but even back when it did, it needed LLVM bitcode, so GCC
wouldn't work anyway.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 30, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@antoyo antoyo enabled auto-merge April 30, 2026 14:31
@antoyo antoyo merged commit 7be6ee1 into rust-lang:master Apr 30, 2026
38 checks passed
@bjorn3 bjorn3 deleted the misc_changes branch April 30, 2026 14:42
@antoyo
Copy link
Copy Markdown
Contributor

antoyo commented Apr 30, 2026

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants