Handle all modules being serialized during LTO#880
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
lto_all_serialized
branch
from
1818556 to
1959b7f
Compare
Member
Author
|
Blocked on rust-lang/rust#156003 |
Contributor
|
I forgot what's the status regarding LTO. |
bjorn3
force-pushed
the
lto_all_serialized
branch
from
1959b7f to
e5622d5
Compare
Member
Author
|
This is for fat LTO. This currently only fixes something that can happen when you combine incremental compilation with fat LTO and all codegen units are unchanged. I want to make some changes to cg_llvm and cg_gcc that would cause this code path to be unconditionally hit for fat LTO. I don't know yet if the performance of that would be acceptable though. I wanted to land the fix in this PR first to make sure I don't regress anything in cg_gcc. |
bjorn3
force-pushed
the
lto_all_serialized
branch
2 times, most recently
from
85012cb to
c6da999
Compare
Member
Author
|
CI passes if I force the new code path to be used. Reverted back to only using it when necessary. Ready for review. |
antoyo
approved these changes
May 6, 2026
Contributor
|
Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.