Fixing path to Configurations.md#2433
Merged
topecongiro merged 1 commit intorust-lang:masterfrom Feb 12, 2018
Merged
Conversation
Issue rust-lang#2419 changed the directory in which `configuration_snippet_tests` runs, which broke the test. Since the test is currently annotated with `#[ignore]`, the break wasn't caught before merge.
Contributor
|
Oops, thank you for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2419 changed the directory in which
configuration_snippet_testsruns, which broke the test. Since the test is currently annotated with#[ignore], the break wasn't caught before merge.Currently, running
cargo test -- --ignoredon master currently yields the following.Running
cargo test -- --ignoredon the PR branch yields the following.