Skip to content

Fixing path to Configurations.md#2433

Merged
topecongiro merged 1 commit intorust-lang:masterfrom
davidalber:unhork-snippet-tests
Feb 12, 2018
Merged

Fixing path to Configurations.md#2433
topecongiro merged 1 commit intorust-lang:masterfrom
davidalber:unhork-snippet-tests

Conversation

@davidalber
Copy link
Copy Markdown
Contributor

Issue #2419 changed the directory in which configuration_snippet_tests runs, which broke the test. Since the test is currently annotated with #[ignore], the break wasn't caught before merge.

Currently, running cargo test -- --ignored on master currently yields the following.

---- configuration_snippet_tests stdout ----
        thread 'configuration_snippet_tests' panicked at 'Couldn't read file Configurations.md: Os { code: 2, kind: NotFound, message: "No such file or directory" }', libcore/result.rs:945:5

Running cargo test -- --ignored on the PR branch yields the following.

.
.
.
---- configuration_snippet_tests stdout ----
        Ran 106 configurations tests.
thread 'configuration_snippet_tests' panicked at 'assertion failed: `(left == right)`
  left: `4`,
 right: `0`: 4 configurations tests failed', rustfmt-core/tests/lib.rs:817:5

Issue rust-lang#2419 changed the directory in which
`configuration_snippet_tests` runs, which broke the test. Since the
test is currently annotated with `#[ignore]`, the break wasn't
caught before merge.
@topecongiro topecongiro merged commit a6982b1 into rust-lang:master Feb 12, 2018
@topecongiro
Copy link
Copy Markdown
Contributor

Oops, thank you for catching this!

@davidalber davidalber deleted the unhork-snippet-tests branch February 12, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants