ci: create rustfmt configs when compiling each rustfmt binary#6775
Merged
ytmimi merged 1 commit intoJan 20, 2026
Merged
Conversation
Before we would allocate a new string for the rustfmt configs every time we invoked rustfmt. This was unnecessary since the configs won't change during the runtime of `check_diff`. Now we'll only create the configs for each binary once. Also, we'll only need to allocate a new string if the user passed a non-empty `--rustfmt-config` option when invoking `check_diff`.
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
@jieyouxu no automatic |
Member
I'll take a look |
Contributor
Author
I appreciate that. No rush though. We'll manage even if we have to manually add the labels for a little while longer. |
Member
#6776 might fix it, I think my rules were too specific previously (internally triagebot uses a globset). |
jieyouxu
approved these changes
Jan 20, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A relatively minor improvement.
Before we would allocate a new string for the rustfmt configs every time we invoked rustfmt. This was unnecessary since the configs won't change during the runtime of
check_diff.Now we'll only create the configs for each binary once. Also, we'll only need to allocate a new string if the user passed a non-empty
--rustfmt-configoption when invokingcheck_diff.