chore(deps): bump annotate-snippets to 0.11.5#6903
Merged
ytmimi merged 1 commit intoMay 22, 2026
Merged
Conversation
Contributor
|
Are there any notable changes from 0.11.4 -> 0.11.5 that would impact formatting? |
Contributor
Author
I tested it locally and didn’t notice any notable formatting changes. Realistically, I wouldn’t expect this update to introduce any diffs apart from diagnostics-related changes. |
Contributor
|
I think it would be helpful if you added similar context to this PR description about the 0.11.4 |
Contributor
|
Just to be safe I'm running the |
Contributor
Author
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lock-only bump ofannotate-snippetsfrom0.11.4to0.11.5. TheCargo.tomlrequirement stays at"0.11"(semver-compatible), so no API adaptation and no breaking change. Prerequisite for #6902 to cover the full reproducer in #6850.Why this is needed
The reproducer in #6850 (a 120-snowman string literal triggering
LineOverflowwitherror_on_unformatted) trips two independent col-vs-byte bugs. The rustfmt-side one is fixed in #6902; the second hides inannotate-snippets 0.11.4itself, in its long-line truncation path atsrc/renderer/display_list.rs:351–373:Same class of bug as the one #6902 fixes on the rustfmt side:
takenaccumulatesunicode_width(visual columns) butcode[..taken.saturating_sub(3)]is a byte slice on a UTF-8 String. On multibyte content the boundary falls inside a codepoint and panics withend byte index N is not a char boundaryatdisplay_list.rs:369.Before #6902, the rustfmt-side bug fired first and masked this one. Once #6902 starts feeding
annotate-snippetscorrect byte ranges, the issue's full reproducer hits this upstream panic instead.annotate-snippetsfixed this in 0.11.5 (release notes:Fix unicode handling in margin-based rendering). BecauseCargo.tomlalready declaresannotate-snippets = "0.11", the bump is just acargo update -p annotate-snippets—Cargo.lockchange only.