Skip to content

Emphasize hotkeys in footer with color#2381

Merged
mo8it merged 4 commits intorust-lang:mainfrom
senekor:senekor/soqukxyvzplr
Apr 25, 2026
Merged

Emphasize hotkeys in footer with color#2381
mo8it merged 4 commits intorust-lang:mainfrom
senekor:senekor/soqukxyvzplr

Conversation

@senekor
Copy link
Copy Markdown
Contributor

@senekor senekor commented Apr 17, 2026

I find this nicer to read than the angle bracket emphasis:

image

This is how it looks with a filter activated:

image

@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 17, 2026

I love it! Since the colors are essential here, did you check whether they are fine for color-blindness?

@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 17, 2026

Maybe also make it bold?

@senekor senekor force-pushed the senekor/soqukxyvzplr branch from 38b1d20 to c59ef64 Compare April 17, 2026 17:28
@senekor
Copy link
Copy Markdown
Contributor Author

senekor commented Apr 17, 2026

did you check whether they are fine for color-blindness?

Not really. It's the same color is the "PENDING" marker in the list of exercises. Also, the user controls the actual colors that are being rendered via their terminal theme / configuration. So, if somebody can't see yellow, presumably they already configured their terminal to render something that's better visible to them.

Maybe also make it bold?

Good idea! Done.

Btw. do you prefer clean history or never force-pushing for PRs? My default is to amend and force-push, but I can do what's more pleasant for you to review.

@senekor senekor force-pushed the senekor/soqukxyvzplr branch 2 times, most recently from c3cee06 to 85b6e70 Compare April 17, 2026 21:06
@senekor senekor force-pushed the senekor/soqukxyvzplr branch from 85b6e70 to 03c5baf Compare April 18, 2026 03:57
@senekor
Copy link
Copy Markdown
Contributor Author

senekor commented Apr 18, 2026

updated screenshots with boldness:

image
image

Comment thread src/list/state.rs Outdated
Comment thread src/list/state.rs
Comment thread src/list/state.rs
@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 20, 2026

Btw. do you prefer clean history or never force-pushing for PRs? My default is to amend and force-push, but I can do what's more pleasant for you to review.

Force-pushing in PRs is fine. But only when the whole direction changes. The goal is not to end up with one commit. Especially changes after a review shouldn't be amended.

@mo8it
Copy link
Copy Markdown
Contributor

mo8it commented Apr 25, 2026

Can you please pull out the function hotkey? Defining a function in a function should only be done when the function is rather small and it has to happen at the top.
I will merge after that nitpick :)

@senekor senekor requested a review from mo8it April 25, 2026 12:10
@mo8it mo8it merged commit 4f1a440 into rust-lang:main Apr 25, 2026
7 checks passed
@senekor senekor deleted the senekor/soqukxyvzplr branch April 25, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants