Emphasize hotkeys in footer with color#2381
Conversation
|
I love it! Since the colors are essential here, did you check whether they are fine for color-blindness? |
|
Maybe also make it bold? |
38b1d20 to
c59ef64
Compare
Not really. It's the same color is the "PENDING" marker in the list of exercises. Also, the user controls the actual colors that are being rendered via their terminal theme / configuration. So, if somebody can't see yellow, presumably they already configured their terminal to render something that's better visible to them.
Good idea! Done. Btw. do you prefer clean history or never force-pushing for PRs? My default is to amend and force-push, but I can do what's more pleasant for you to review. |
c3cee06 to
85b6e70
Compare
85b6e70 to
03c5baf
Compare
Force-pushing in PRs is fine. But only when the whole direction changes. The goal is not to end up with one commit. Especially changes after a review shouldn't be amended. |
|
Can you please pull out the function |


I find this nicer to read than the angle bracket emphasis:
This is how it looks with a filter activated: