Skip to content

fix(ci): use github.event_name == 'push' instead of github.event.push#3627

Merged
rami3l merged 1 commit intomasterfrom
fix/ci-push-pred
Jan 4, 2024
Merged

fix(ci): use github.event_name == 'push' instead of github.event.push#3627
rami3l merged 1 commit intomasterfrom
fix/ci-push-pred

Conversation

@rami3l
Copy link
Copy Markdown
Member

@rami3l rami3l commented Jan 4, 2024

Tries to address the concern in #3582 (comment).

github.event.push is the suspect here since:

  • ... it triggers Context access might be invalid warnings in VSCode;
  • github.event_name == 'push' seem to work elsewhere in ci.yaml.

@rami3l rami3l merged commit 578696b into master Jan 4, 2024
@rami3l rami3l deleted the fix/ci-push-pred branch January 4, 2024 17:19
@rami3l rami3l mentioned this pull request Jan 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants