Skip to content

Conversation

@cachebag
Copy link
Contributor

@cachebag cachebag commented Nov 3, 2025

Draft for #4442

@cachebag
Copy link
Contributor Author

cachebag commented Nov 4, 2025

@djc

As a note
I did end up attempting to reproduce #4442 on my MacBook using my branch. The environment was configured with a clean RUSTUP_HOME and CARGO_HOME, and the custom build (--no-default-features) behaved as expected without triggering the original failure.

stable rustup with skip_std flag

image

with patch applied

image

I hope I understood this correctly. I believe I am still doing something wrong with the propogation as even a false flag triggers the new behavior
image

But I'd like to defer to you guys before I continue.

src/install.rs Outdated
cfg: &'a Cfg<'a>,
},
Dist(DistOptions<'a>),
Dist(DistOptions<'a>, bool),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to keep this inside DistOptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants