-
Notifications
You must be signed in to change notification settings - Fork 994
feat: Added xonsh shell support - try 1 #4623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems reasonable to me, thanks! @rami3l do you want to take a look?
(Please squash all your commits.)
|
Test instructions for the future: docker run --rm -it rust
apt update && apt install -y python3 python3-pip
pip install --break-system-packages xonsh
xonsh
git clone -b xonsh_shell https://github.com/anki-code/rustup
cd rustup/
# https://rust-lang.github.io/rustup/dev-guide/
cargo build
mkdir home
$RUSTUP_HOME='home' $CARGO_HOME='home' target/debug/rustup-init --no-modify-path -y
source /rustup/home/env.xsh
$PATH.pop(0) # remove '/usr/local/cargo/bin' from container
which cargo
# /rustup/home/bin/cargo
cargo --version
# cargo 1.91.1@djc, thanks for the review! Sorry I can't do squash because the branch has commits from github editor and from local (error "commit has two parents") but check your merge button. Ordinarily it has squash option. |
Not here, because we have the merge queue enabled. You should be able to squash all the commits using |


Resolve #4622