Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,32 @@ use std::env;
use platforms::Platform;

fn from_build() -> Result<String, String> {
let triple =
env::var("RUSTUP_OVERRIDE_BUILD_TRIPLE").unwrap_or_else(|_| env::var("TARGET").unwrap());
if Platform::ALL.iter().any(|p| p.target_triple == triple) {
Ok(triple)
let tuple = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd prefer to avoid the outer scope here, it doesn't seem all that useful?

if let Ok(tuple) = env::var("RUSTUP_OVERRIDE_BUILD_TUPLE") {
tuple
} else if let Ok(tuple) = env::var("RUSTUP_OVERRIDE_BUILD_TRIPLE") {
tuple
} else if let Ok(tuple) = env::var("TARGET") {
tuple
} else {
panic!(
"Unable to get target tuple from environment; Be sure that TARGET env var, or its override, is set"
)
}
};
if Platform::ALL.iter().any(|p| p.target_triple == tuple) {
Ok(tuple)
} else {
Err(triple)
Err(tuple)
}
}

fn main() {
println!("cargo::rerun-if-env-changed=RUSTUP_OVERRIDE_BUILD_TUPLE");
println!("cargo::rerun-if-env-changed=RUSTUP_OVERRIDE_BUILD_TRIPLE");
println!("cargo::rerun-if-env-changed=TARGET");
match from_build() {
Ok(triple) => eprintln!("Computed build based on target tuple: {triple:#?}"),
Ok(tuple) => eprintln!("Computed build based on target tuple: {tuple:#?}"),
Err(s) => {
eprintln!("Unable to parse target '{s}' as a known target tuple");
eprintln!(
Expand Down
2 changes: 1 addition & 1 deletion src/cli/self_update.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,7 @@ pub(crate) async fn prepare_update(dl_cfg: &DownloadCfg<'_>) -> Result<Option<Pa
// This ensures that we update to a version that's appropriate for users
// and also works around if the website messed up the detection.
// If someone really wants to use another version, they still can enforce
// that using the environment variable RUSTUP_OVERRIDE_HOST_TRIPLE.
// that using the environment variable RUSTUP_OVERRIDE_HOST_TUPLE.
#[cfg(windows)]
let triple = TargetTriple::from_host(dl_cfg.process).unwrap_or(triple);

Expand Down
12 changes: 8 additions & 4 deletions src/dist/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,10 @@ impl TargetTriple {
}

pub(crate) fn from_build() -> Self {
if let Some(triple) = option_env!("RUSTUP_OVERRIDE_BUILD_TRIPLE") {
Self::new(triple)
if let Some(tuple) = option_env!("RUSTUP_OVERRIDE_BUILD_TUPLE") {
Self::new(tuple)
} else if let Some(tuple) = option_env!("RUSTUP_OVERRIDE_BUILD_TRIPLE") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a warning here to deprecate and eventually remove this environment variable? IIRC we don't document it and it should only be used by rustup itself but I wouldn't be surprise if it's used by someone else who read the code. A warning for a version or two should hopefully help them.

Self::new(tuple)
} else {
Self::new(env!("TARGET"))
}
Expand Down Expand Up @@ -549,8 +551,10 @@ impl TargetTriple {
host_triple.map(TargetTriple::new)
}

if let Ok(triple) = process.var("RUSTUP_OVERRIDE_HOST_TRIPLE") {
Some(Self(triple))
if let Ok(tuple) = process.var("RUSTUP_OVERRIDE_HOST_TUPLE") {
Some(Self(tuple))
} else if let Ok(tuple) = process.var("RUSTUP_OVERRIDE_HOST_TRIPLE") {
Some(Self(tuple))
} else {
inner()
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/clitools.rs
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ impl Config {
format!("file://{}", distdir.to_string_lossy()),
);
cmd.env("CARGO_HOME", self.cargodir.to_string_lossy().to_string());
cmd.env("RUSTUP_OVERRIDE_HOST_TRIPLE", this_host_triple());
cmd.env("RUSTUP_OVERRIDE_HOST_TUPLE", this_host_triple());

// These are used in some installation tests that unset RUSTUP_HOME/CARGO_HOME
cmd.env("HOME", self.homedir.to_string_lossy().to_string());
Expand Down